bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Remove highlighting of spans on -Zteach

Browse source 
`-Zteach` is perma-unstable, barely used, the highlighting logic buggy and the flag being passed around is tech-debt. We should likely remove `-Zteach` in its entirely.
This commit is contained in:
Esteban Küber 2025-02-27 21:09:45 +00:00
parent 03eb454523
commit d975bd3a67
3 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

11
compiler/rustc_errors/src/emitter.rs
View file

@ -616,7 +616,6 @@ pub struct HumanEmitter {
#[setters(skip)]
fallback_bundle: LazyFallbackBundle,
short_message: bool,
teach: bool,
ui_testing: bool,
ignored_directories_in_source_blocks: Vec<String>,
diagnostic_width: Option<usize>,
@ -642,7 +641,6 @@ impl HumanEmitter {
fluent_bundle: None,
fallback_bundle,
short_message: false,
teach: false,
ui_testing: false,
ignored_directories_in_source_blocks: Vec::new(),
diagnostic_width: None,
@ -1044,15 +1042,6 @@ impl HumanEmitter {
underline.style,
);
}
_ if self.teach => {
buffer.set_style_range(
line_offset,
(code_offset + annotation.start_col.display).saturating_sub(left),
(code_offset + annotation.end_col.display).saturating_sub(left),
underline.style,
annotation.is_primary,
);
}
_ => {}
}
}