1
Fork 0

Rollup merge of #100301 - TaKO8Ki:avoid-&str-to-String-conversions, r=compiler-errors

Avoid `&str` to `String` conversions

This patch removes the recently added unnecessary `&str` to `String` conversions.

follow-up to #99718
This commit is contained in:
Dylan DPC 2022-08-09 17:34:56 +05:30 committed by GitHub
commit d7f414d540
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1589,11 +1589,11 @@ impl<'tcx, 'exprs, E: AsCoercionSite> CoerceMany<'tcx, 'exprs, E> {
) {
let hir::ExprKind::Loop(_, _, _, loop_span) = expr.kind else { return;};
let mut span: MultiSpan = vec![loop_span].into();
span.push_span_label(loop_span, "this might have zero elements to iterate on".to_string());
span.push_span_label(loop_span, "this might have zero elements to iterate on");
for ret_expr in ret_exprs {
span.push_span_label(
ret_expr.span,
"if the loop doesn't execute, this value would never get returned".to_string(),
"if the loop doesn't execute, this value would never get returned",
);
}
err.span_note(