1
Fork 0

Remove an unnecessary lifetime

This commit is contained in:
Oli Scherer 2025-02-24 08:07:11 +00:00
parent a54bfcf52b
commit d4379d2afd
6 changed files with 11 additions and 11 deletions

View file

@ -59,7 +59,7 @@ pub fn type_is_pointer(typ: Type<'_>) -> bool {
typ.get_pointee().is_some() typ.get_pointee().is_some()
} }
impl<'gcc, 'tcx> ConstCodegenMethods<'tcx> for CodegenCx<'gcc, 'tcx> { impl<'gcc, 'tcx> ConstCodegenMethods for CodegenCx<'gcc, 'tcx> {
fn const_null(&self, typ: Type<'gcc>) -> RValue<'gcc> { fn const_null(&self, typ: Type<'gcc>) -> RValue<'gcc> {
if type_is_pointer(typ) { self.context.new_null(typ) } else { self.const_int(typ, 0) } if type_is_pointer(typ) { self.context.new_null(typ) } else { self.const_int(typ, 0) }
} }
@ -263,7 +263,7 @@ impl<'gcc, 'tcx> ConstCodegenMethods<'tcx> for CodegenCx<'gcc, 'tcx> {
} }
} }
fn const_data_from_alloc(&self, alloc: ConstAllocation<'tcx>) -> Self::Value { fn const_data_from_alloc(&self, alloc: ConstAllocation<'_>) -> Self::Value {
const_alloc_to_gcc(self, alloc) const_alloc_to_gcc(self, alloc)
} }

View file

@ -302,9 +302,9 @@ impl<'gcc, 'tcx> CodegenCx<'gcc, 'tcx> {
} }
} }
pub fn const_alloc_to_gcc<'gcc, 'tcx>( pub fn const_alloc_to_gcc<'gcc>(
cx: &CodegenCx<'gcc, 'tcx>, cx: &CodegenCx<'gcc, '_>,
alloc: ConstAllocation<'tcx>, alloc: ConstAllocation<'_>,
) -> RValue<'gcc> { ) -> RValue<'gcc> {
let alloc = alloc.inner(); let alloc = alloc.inner();
let mut llvals = Vec::with_capacity(alloc.provenance().ptrs().len() + 1); let mut llvals = Vec::with_capacity(alloc.provenance().ptrs().len() + 1);

View file

@ -118,7 +118,7 @@ impl<'ll> CodegenCx<'ll, '_> {
} }
} }
impl<'ll, 'tcx> ConstCodegenMethods<'tcx> for CodegenCx<'ll, 'tcx> { impl<'ll, 'tcx> ConstCodegenMethods for CodegenCx<'ll, 'tcx> {
fn const_null(&self, t: &'ll Type) -> &'ll Value { fn const_null(&self, t: &'ll Type) -> &'ll Value {
unsafe { llvm::LLVMConstNull(t) } unsafe { llvm::LLVMConstNull(t) }
} }
@ -350,7 +350,7 @@ impl<'ll, 'tcx> ConstCodegenMethods<'tcx> for CodegenCx<'ll, 'tcx> {
} }
} }
fn const_data_from_alloc(&self, alloc: ConstAllocation<'tcx>) -> Self::Value { fn const_data_from_alloc(&self, alloc: ConstAllocation<'_>) -> Self::Value {
const_alloc_to_llvm(self, alloc, /*static*/ false) const_alloc_to_llvm(self, alloc, /*static*/ false)
} }

View file

@ -133,7 +133,7 @@ impl<'a, 'tcx, V: CodegenObject> PlaceRef<'tcx, V> {
Self::alloca(bx, ptr_layout) Self::alloca(bx, ptr_layout)
} }
pub fn len<Cx: ConstCodegenMethods<'tcx, Value = V>>(&self, cx: &Cx) -> V { pub fn len<Cx: ConstCodegenMethods<Value = V>>(&self, cx: &Cx) -> V {
if let FieldsShape::Array { count, .. } = self.layout.fields { if let FieldsShape::Array { count, .. } = self.layout.fields {
if self.layout.is_unsized() { if self.layout.is_unsized() {
assert_eq!(count, 0); assert_eq!(count, 0);

View file

@ -3,7 +3,7 @@ use rustc_middle::mir::interpret::{ConstAllocation, Scalar};
use super::BackendTypes; use super::BackendTypes;
pub trait ConstCodegenMethods<'tcx>: BackendTypes { pub trait ConstCodegenMethods: BackendTypes {
// Constant constructors // Constant constructors
fn const_null(&self, t: Self::Type) -> Self::Value; fn const_null(&self, t: Self::Type) -> Self::Value;
/// Generate an uninitialized value (matching uninitialized memory in MIR). /// Generate an uninitialized value (matching uninitialized memory in MIR).
@ -38,7 +38,7 @@ pub trait ConstCodegenMethods<'tcx>: BackendTypes {
fn const_to_opt_uint(&self, v: Self::Value) -> Option<u64>; fn const_to_opt_uint(&self, v: Self::Value) -> Option<u64>;
fn const_to_opt_u128(&self, v: Self::Value, sign_ext: bool) -> Option<u128>; fn const_to_opt_u128(&self, v: Self::Value, sign_ext: bool) -> Option<u128>;
fn const_data_from_alloc(&self, alloc: ConstAllocation<'tcx>) -> Self::Value; fn const_data_from_alloc(&self, alloc: ConstAllocation<'_>) -> Self::Value;
fn scalar_to_backend(&self, cv: Scalar, layout: abi::Scalar, llty: Self::Type) -> Self::Value; fn scalar_to_backend(&self, cv: Scalar, layout: abi::Scalar, llty: Self::Type) -> Self::Value;

View file

@ -55,7 +55,7 @@ pub trait CodegenObject = Copy + PartialEq + fmt::Debug;
pub trait CodegenMethods<'tcx> = LayoutOf<'tcx, LayoutOfResult = TyAndLayout<'tcx>> pub trait CodegenMethods<'tcx> = LayoutOf<'tcx, LayoutOfResult = TyAndLayout<'tcx>>
+ FnAbiOf<'tcx, FnAbiOfResult = &'tcx FnAbi<'tcx, Ty<'tcx>>> + FnAbiOf<'tcx, FnAbiOfResult = &'tcx FnAbi<'tcx, Ty<'tcx>>>
+ TypeCodegenMethods<'tcx> + TypeCodegenMethods<'tcx>
+ ConstCodegenMethods<'tcx> + ConstCodegenMethods
+ StaticCodegenMethods + StaticCodegenMethods
+ DebugInfoCodegenMethods<'tcx> + DebugInfoCodegenMethods<'tcx>
+ AsmCodegenMethods<'tcx> + AsmCodegenMethods<'tcx>