bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #38413 - rillian:armv7-neon, r=alexcrichton

Browse source 
rustc: Disable NEON on armv7 android.

We thought Google's ABI for arvm7 required neon, but it is
currently optional, perhaps because there is a significant
population of Tegra 2 devices still in use.

This turns off neon code generation outside #[target-feature]
blocks just like we do on armv7-unknown-linux-gnu, but unlike
most other armv7 targets. LLVM defaults to +neon for this target,
so an explicit disable is necessary.

See https://developer.android.com/ndk/guides/abis.html#v7a
for instruction set extension requirements.

Closes #38402.
This commit is contained in:
Seo Sanghyeon 2016-12-19 16:59:37 +09:00 • committed by GitHub
commit d38beccdc4
3 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/librustc_back/target/aarch64_linux_android.rs
View file

@ -10,6 +10,9 @@
use target::{Target, TargetOptions, TargetResult};
// See https://developer.android.com/ndk/guides/abis.html#arm64-v8a
// for target ABI requirements.
pub fn target() -> TargetResult {
let mut base = super::android_base::opts();
base.max_atomic_width = Some(128);

7
src/librustc_back/target/armv7_linux_androideabi.rs
View file

@ -1,4 +1,4 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
@ -10,9 +10,12 @@
use target::{Target, TargetOptions, TargetResult};
// See https://developer.android.com/ndk/guides/abis.html#v7a
// for target ABI requirements.
pub fn target() -> TargetResult {
let mut base = super::android_base::opts();
base.features = "+v7,+thumb2,+vfp3,+d16".to_string();
base.features = "+v7,+thumb2,+vfp3,+d16,-neon".to_string();
base.max_atomic_width = Some(64);
Ok(Target {

3
src/librustc_back/target/i686_linux_android.rs
View file

@ -10,6 +10,9 @@
use target::{Target, TargetResult};
// See https://developer.android.com/ndk/guides/abis.html#x86
// for target ABI requirements.
pub fn target() -> TargetResult {
let mut base = super::android_base::opts();