bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

author: check block.expr: None

Browse source
This commit is contained in:
Cameron Steffen 2021-07-25 16:35:35 -05:00
parent afe5962d38
commit d3492a0894
4 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/utils/author.rs
View file

@ -554,6 +554,8 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
self.current = self.next("trailing_expr"); self.current = self.next("trailing_expr");
println!(" if let Some({}) = &{}.expr;", self.current, block_name); println!(" if let Some({}) = &{}.expr;", self.current, block_name);
self.visit_expr(expr); self.visit_expr(expr);
} else {
println!(" if {}.expr.is_none();", block_name);
} }
} }

1
tests/ui/author/blocks.stdout
View file

@ -11,6 +11,7 @@ if_chain! {
if let ExprKind::Unary(UnOp::Neg, ref inner) = e.kind; if let ExprKind::Unary(UnOp::Neg, ref inner) = e.kind;
if let ExprKind::Path(ref path) = inner.kind; if let ExprKind::Path(ref path) = inner.kind;
if match_qpath(path, &["x"]); if match_qpath(path, &["x"]);
if block.expr.is_none();
then { then {
// report your lint here // report your lint here
} }

2
tests/ui/author/for_loop.stdout
View file

@ -54,6 +54,8 @@ if_chain! {
if match_qpath(path9, &["y"]); if match_qpath(path9, &["y"]);
if let PatKind::Binding(BindingAnnotation::Unannotated, _, name2, None) = local2.pat.kind; if let PatKind::Binding(BindingAnnotation::Unannotated, _, name2, None) = local2.pat.kind;
if name2.as_str() == "z"; if name2.as_str() == "z";
if block.expr.is_none();
if body.expr.is_none();
if let PatKind::Binding(BindingAnnotation::Mutable, _, name3, None) = arms[0].pat.kind; if let PatKind::Binding(BindingAnnotation::Mutable, _, name3, None) = arms[0].pat.kind;
if name3.as_str() == "iter"; if name3.as_str() == "iter";
then { then {

2
tests/ui/author/if.stdout
View file

@ -11,6 +11,7 @@ if_chain! {
if let LitKind::Int(2, _) = lit.node; if let LitKind::Int(2, _) = lit.node;
if let ExprKind::Lit(ref lit1) = right.kind; if let ExprKind::Lit(ref lit1) = right.kind;
if let LitKind::Int(2, _) = lit1.node; if let LitKind::Int(2, _) = lit1.node;
if block.expr.is_none();
if let ExprKind::Lit(ref lit2) = cond.kind; if let ExprKind::Lit(ref lit2) = cond.kind;
if let LitKind::Bool(true) = lit2.node; if let LitKind::Bool(true) = lit2.node;
if let ExprKind::Block(ref block1) = then.kind; if let ExprKind::Block(ref block1) = then.kind;
@ -22,6 +23,7 @@ if_chain! {
if let LitKind::Int(1, _) = lit3.node; if let LitKind::Int(1, _) = lit3.node;
if let ExprKind::Lit(ref lit4) = right1.kind; if let ExprKind::Lit(ref lit4) = right1.kind;
if let LitKind::Int(1, _) = lit4.node; if let LitKind::Int(1, _) = lit4.node;
if block1.expr.is_none();
if let PatKind::Wild = local.pat.kind; if let PatKind::Wild = local.pat.kind;
then { then {
// report your lint here // report your lint here