bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Fix a parser ICE on invalid fn body

Browse source
This commit is contained in:
Yuki Okushi 2021-07-31 06:09:54 +09:00
parent f3f8e758f2
commit d2d851949b
No known key found for this signature in database
GPG key ID: DABA5B072961C18A
3 changed files with 29 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_parse/src/parser/item.rs
View file

@ -1715,13 +1715,11 @@ impl<'a> Parser<'a> {
// the AST for typechecking. // the AST for typechecking.
err.span_label(ident.span, "while parsing this `fn`"); err.span_label(ident.span, "while parsing this `fn`");
err.emit(); err.emit();
(Vec::new(), None)
} else { } else {
return Err(err); return Err(err);
} }
} else {
unreachable!()
} }
(Vec::new(), None)
}; };
attrs.extend(inner_attrs); attrs.extend(inner_attrs);
Ok(body) Ok(body)

9
src/test/ui/parser/issue-87635.rs Normal file
View file

@ -0,0 +1,9 @@
struct Foo {}
impl Foo {
pub fn bar()
//~^ ERROR: expected `;`, found `}`
//~| ERROR: associated function in `impl` without body
}
fn main() {}

19
src/test/ui/parser/issue-87635.stderr Normal file
View file

@ -0,0 +1,19 @@
error: expected `;`, found `}`
--> $DIR/issue-87635.rs:4:17
|
LL | pub fn bar()
| ^ help: add `;` here
...
LL | }
| - unexpected token
error: associated function in `impl` without body
--> $DIR/issue-87635.rs:4:5
|
LL | pub fn bar()
| ^^^^^^^^^^^-
| |
| help: provide a definition for the function: `{ <body> }`
error: aborting due to 2 previous errors