bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Fix invalid camel case suggestion involving unicode idents

Browse source 
Follow up to #77805.
This commit is contained in:
Esteban Küber 2021-01-29 11:07:14 -08:00
parent bf193d69fe
commit d10ee0d07e
2 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_lint/src/nonstandard_style.rs
View file

@ -57,7 +57,7 @@ declare_lint! {
declare_lint_pass!(NonCamelCaseTypes => [NON_CAMEL_CASE_TYPES]);
fn char_has_case(c: char) -> bool {
c.is_lowercase() || c.is_uppercase()
c.to_lowercase().to_string() != c.to_uppercase().to_string()
}
fn is_camel_case(name: &str) -> bool {
@ -138,6 +138,8 @@ impl NonCamelCaseTypes {
to_camel_case(name),
Applicability::MaybeIncorrect,
);
} else {
err.span_label(ident.span, "should have an UpperCamelCase name");
}
err.emit();
@ -299,6 +301,8 @@ impl NonSnakeCase {
} else {
err.help(&format!("convert the identifier to snake case: `{}`", sc));
}
} else {
err.span_label(ident.span, "should have a snake_case name");
}
err.emit();
@ -477,6 +481,8 @@ impl NonUpperCaseGlobals {
uc,
Applicability::MaybeIncorrect,
);
} else {
err.span_label(ident.span, "should have an UPPER_CASE name");
}
err.emit();