bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add 'consider using' message to overflowing_literals

Browse source 
Ironically, the overflowing_literals handler for binary or hex already
had this message! You would think it would be the other way around :)
This commit is contained in:
Camelid 2020-12-12 13:46:25 -08:00
parent 5bb68c31f8
commit d00ca11202
9 changed files with 66 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

29
compiler/rustc_lint/src/types.rs
View file

@ -331,18 +331,23 @@ fn lint_int_literal<'tcx>(
}
cx.struct_span_lint(OVERFLOWING_LITERALS, e.span, |lint| {
lint.build(&format!("literal out of range for `{}`", t.name_str()))
.note(&format!(
"the literal `{}` does not fit into the type `{}` whose range is `{}..={}`",
cx.sess()
.source_map()
.span_to_snippet(lit.span)
.expect("must get snippet from literal"),
t.name_str(),
min,
max,
))
.emit();
let mut err = lint.build(&format!("literal out of range for `{}`", t.name_str()));
err.note(&format!(
"the literal `{}` does not fit into the type `{}` whose range is `{}..={}`",
cx.sess()
.source_map()
.span_to_snippet(lit.span)
.expect("must get snippet from literal"),
t.name_str(),
min,
max,
));
if let Some(sugg_ty) =
get_type_suggestion(&cx.typeck_results().node_type(e.hir_id), v, negative)
{
err.help(&format!("consider using `{}` instead", sugg_ty));
}
err.emit();
});
}
}