bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: fix help menu popover toggling

Browse source
This commit is contained in:
Michael Howell 2022-06-28 14:16:05 -07:00
parent 94e93749ab
commit cec6988a07
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/librustdoc/html/static/js/main.js
View file

@ -926,6 +926,7 @@ function loadCss(cssFileName) {
function showHelp() { function showHelp() {
const menu = getHelpMenu(true); const menu = getHelpMenu(true);
if (menu.style.display === "none") { if (menu.style.display === "none") {
window.hidePopoverMenus();
menu.style.display = ""; menu.style.display = "";
} }
} }
@ -939,6 +940,8 @@ function loadCss(cssFileName) {
const shouldShowHelp = menu.style.display === "none"; const shouldShowHelp = menu.style.display === "none";
if (shouldShowHelp) { if (shouldShowHelp) {
showHelp(); showHelp();
} else {
window.hidePopoverMenus();
} }
}); });

5
src/test/rustdoc-gui/pocket-menu.goml
View file

@ -24,6 +24,11 @@ click: "#help-button"
assert-css: ("#help-button .popover", {"display": "block"}) assert-css: ("#help-button .popover", {"display": "block"})
assert-css: ("#settings-menu .popover", {"display": "none"}) assert-css: ("#settings-menu .popover", {"display": "none"})
// Now verify that clicking the help menu again closes it.
click: "#help-button"
assert-css: ("#help-button .popover", {"display": "none"})
assert-css: ("#settings-menu .popover", {"display": "none"})
// We check the borders color now: // We check the borders color now:
// Ayu theme // Ayu theme