bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

clarify target_feature + forced inlining

Browse source
This commit is contained in:
David Wood 2024-12-18 13:54:41 +00:00
parent 3169a4493f
commit ce602acfc2
No known key found for this signature in database
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
compiler/rustc_codegen_ssa/src/codegen_attrs.rs
View file

@ -627,17 +627,19 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, did: LocalDefId) -> CodegenFnAttrs {
// enabled. For that reason we also forbid `#[inline(always)]` as it can't be // enabled. For that reason we also forbid `#[inline(always)]` as it can't be
// respected. // respected.
// //
// `#[rustc_force_inline]` doesn't need to be prohibited here, that // `#[rustc_force_inline]` doesn't need to be prohibited here, only
// is implemented entirely in rustc can attempt to inline and error if it cannot. // `#[inline(always)]`, as forced inlining is implemented entirely within
// rustc (and so the MIR inliner can do any necessary checks for compatible target
// features).
//
// This sidesteps the LLVM blockers in enabling `target_features` +
// `inline(always)` to be used together (see rust-lang/rust#116573 and
// llvm/llvm-project#70563).
if !codegen_fn_attrs.target_features.is_empty() if !codegen_fn_attrs.target_features.is_empty()
&& matches!(codegen_fn_attrs.inline, InlineAttr::Always) && matches!(codegen_fn_attrs.inline, InlineAttr::Always)
{ {
if let Some(span) = inline_span { if let Some(span) = inline_span {
tcx.dcx().span_err( tcx.dcx().span_err(span, "cannot use `#[inline(always)]` with `#[target_feature]`");
span,
"cannot use `#[inline(always)]` with \
`#[target_feature]`",
);
} }
} }