bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Rollup merge of #122954 - fmease:defined-by-extern-prelude, r=petrochenkov

Browse source 
Be more specific when flagging imports as redundant due to the extern prelude

There are multiple distinct kinds of [preludes](https://doc.rust-lang.org/reference/names/preludes.html). Be more specific when flagging imports as redundant due to the [extern prelude](https://doc.rust-lang.org/reference/names/preludes.html#extern-prelude).

r? Nilstrieb or compiler
This commit is contained in:
León Orell Valerian Liehr 2024-04-11 01:56:24 +02:00 • committed by GitHub
commit ccab2b16d3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 108 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_lint/src/context/diagnostics.rs
View file

@ -105,7 +105,7 @@ pub(super) fn builtin(sess: &Session, diagnostic: BuiltinLintDiag, diag: &mut Di
BuiltinLintDiag::RedundantImport(spans, ident) => {
for (span, is_imported) in spans {
let introduced = if is_imported { "imported" } else { "defined" };
let span_msg = if span.is_dummy() { "by prelude" } else { "here" };
let span_msg = if span.is_dummy() { "by the extern prelude" } else { "here" };
diag.span_label(
span,
format!("the item `{ident}` is already {introduced} {span_msg}"),