bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #92294 - Kobzol:rustdoc-meta-kind, r=GuillaumeGomez

Browse source 
Add Attribute::meta_kind

The `AttrItem::meta` function is being called on a lot of places, however almost always the caller is only interested in the `kind` of the result `MetaItem`. Before, the `path`  had to be cloned in order to get the kind, now it does not have to be.

There is a larger related "problem". In a lot of places, something wants to know contents of attributes. This is accessed through `Attribute::meta_item_list`, which calls `AttrItem::meta` (now `AttrItem::meta_kind`), among other methods. When this function is called, the meta item list has to be recreated from scratch. Everytime something asks a simple question (like is this item/list of attributes `#[doc(hidden)]`?), the tokens of the attribute(s) are cloned, parsed and the results are allocated on the heap. That seems really unnecessary. What would be the best way to cache this? Turn `meta_item_list` into a query perhaps? Related PR: https://github.com/rust-lang/rust/pull/92227

r? rust-lang/rustdoc
This commit is contained in:
bors 2022-01-01 02:03:23 +00:00
commit c9cf9c6507
4 changed files with 32 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_interface/src/util.rs
View file

@ -484,7 +484,7 @@ pub(crate) fn check_attr_crate_type(
return;
}
if let ast::MetaItemKind::NameValue(spanned) = a.meta().unwrap().kind {
if let ast::MetaItemKind::NameValue(spanned) = a.meta_kind().unwrap() {
let span = spanned.span;
let lev_candidate = find_best_match_for_name(
&CRATE_TYPES.iter().map(|(k, _)| *k).collect::<Vec<_>>(),