bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: filter before storing in vec

Browse source
This commit is contained in:
Michael Howell 2023-09-10 09:17:24 -07:00 • committed by GitHub
parent c3e5ad448b
commit c79b960747
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/librustdoc/html/render/context.rs
View file

@ -159,8 +159,15 @@ impl SharedContext<'_> {
) -> Vec<&'a formats::Impl> { ) -> Vec<&'a formats::Impl> {
let tcx = self.tcx; let tcx = self.tcx;
let cache = &self.cache; let cache = &self.cache;
let mut v: Vec<&formats::Impl> = let mut saw_impls = FxHashSet::default();
cache.impls.get(&did).map(Vec::as_slice).unwrap_or(&[]).iter().collect(); let mut v: Vec<&formats::Impl> = cache
.impls
.get(&did)
.map(Vec::as_slice)
.unwrap_or(&[])
.iter()
.filter(|i| saw_impls.insert(i.def_id()))
.collect();
if let TypeAliasItem(ait) = &*it.kind && if let TypeAliasItem(ait) = &*it.kind &&
let aliased_clean_type = ait.item_type.as_ref().unwrap_or(&ait.type_) && let aliased_clean_type = ait.item_type.as_ref().unwrap_or(&ait.type_) &&
let Some(aliased_type_defid) = aliased_clean_type.def_id(cache) && let Some(aliased_type_defid) = aliased_clean_type.def_id(cache) &&
@ -181,13 +188,12 @@ impl SharedContext<'_> {
v.extend(av.iter().filter(|impl_| { v.extend(av.iter().filter(|impl_| {
if let Some(impl_def_id) = impl_.impl_item.item_id.as_def_id() { if let Some(impl_def_id) = impl_.impl_item.item_id.as_def_id() {
reject_cx.types_may_unify(aliased_ty, tcx.type_of(impl_def_id).skip_binder()) reject_cx.types_may_unify(aliased_ty, tcx.type_of(impl_def_id).skip_binder())
&& saw_impls.insert(impl_def_id)
} else { } else {
false false
} }
})); }));
} }
let mut saw_impls = FxHashSet::default();
v.retain(|i| saw_impls.insert(i.def_id()));
v v
} }
} }