bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

mk: Fix rpath on cross compile builds

Browse source 
After removing absolute rpaths, cross compile builds (notably the nightly
builders) broke. This is because the RPATH was pointing at an empty directory
because only the rustc binary is copied over, not all of the target libraries.
This modifies the cross compile logic to fixup the rpath of the stage0
cross-compiled rustc to point to where it came from.
This commit is contained in:
Alex Crichton 2014-04-11 10:52:01 -07:00
parent 65abf96fb6
commit c60d9ad57c
1 changed files with 36 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

44
mk/main.mk
View file

@ -349,14 +349,12 @@ EXTRAFLAGS_STAGE$(1) = $$(RUSTFLAGS_STAGE$(1))
CFGFLAG$(1)_T_$(2)_H_$(3) = stage$(1) CFGFLAG$(1)_T_$(2)_H_$(3) = stage$(1)
# Pass --cfg stage0 only for the build->host part of stage0; endef
# if you're building a cross config, the host->* parts are
# effectively stage1, since it uses the just-built stage0. # Same macro/variables as above, but defined in a separate loop so it can use
ifeq ($(1),0) # all the varibles above for all archs. The RPATH_VAR setup sometimes needs to
ifneq ($(strip $(CFG_BUILD)),$(strip $(3))) # reach across triples to get things in order.
CFGFLAG$(1)_T_$(2)_H_$(3) = stage1 define SREQ_CMDS
endif
endif
ifeq ($$(OSTYPE_$(3)),apple-darwin) ifeq ($$(OSTYPE_$(3)),apple-darwin)
RPATH_VAR$(1)_T_$(2)_H_$(3) := \ RPATH_VAR$(1)_T_$(2)_H_$(3) := \
@ -366,6 +364,31 @@ else
LD_LIBRARY_PATH="$$$$LD_LIBRARY_PATH:$$(CURDIR)/$$(HLIB$(1)_H_$(3))" LD_LIBRARY_PATH="$$$$LD_LIBRARY_PATH:$$(CURDIR)/$$(HLIB$(1)_H_$(3))"
endif endif
# Pass --cfg stage0 only for the build->host part of stage0;
# if you're building a cross config, the host->* parts are
# effectively stage1, since it uses the just-built stage0.
#
# This logic is similar to how the LD_LIBRARY_PATH variable must
# change be slightly different when doing cross compilations.
# The build doesn't copy over all target libraries into
# a new directory, so we need to point the library path at
# the build directory where all the target libraries came
# from (the stage0 build host). Otherwise the relative rpaths
# inside of the rustc binary won't get resolved correctly.
ifeq ($(1),0)
ifneq ($(strip $(CFG_BUILD)),$(strip $(3)))
CFGFLAG$(1)_T_$(2)_H_$(3) = stage1
ifeq ($$(OSTYPE_$(3)),apple-darwin)
RPATH_VAR$(1)_T_$(2)_H_$(3) := \
DYLD_LIBRARY_PATH="$$$$DYLD_LIBRARY_PATH:$$(CURDIR)/$$(TLIB1_T_$(2)_H_$(CFG_BUILD))"
else
RPATH_VAR$(1)_T_$(2)_H_$(3) := \
LD_LIBRARY_PATH="$$$$LD_LIBRARY_PATH:$$(CURDIR)/$$(TLIB1_T_$(2)_H_$(CFG_BUILD))"
endif
endif
endif
STAGE$(1)_T_$(2)_H_$(3) := \ STAGE$(1)_T_$(2)_H_$(3) := \
$$(Q)$$(RPATH_VAR$(1)_T_$(2)_H_$(3)) \ $$(Q)$$(RPATH_VAR$(1)_T_$(2)_H_$(3)) \
$$(call CFG_RUN_TARG_$(3),$(1), \ $$(call CFG_RUN_TARG_$(3),$(1), \
@ -390,6 +413,11 @@ $(foreach build,$(CFG_HOST), \
$(eval $(foreach stage,$(STAGES), \ $(eval $(foreach stage,$(STAGES), \
$(eval $(call SREQ,$(stage),$(target),$(build)))))))) $(eval $(call SREQ,$(stage),$(target),$(build))))))))
$(foreach build,$(CFG_HOST), \
$(eval $(foreach target,$(CFG_TARGET), \
$(eval $(foreach stage,$(STAGES), \
$(eval $(call SREQ_CMDS,$(stage),$(target),$(build))))))))
###################################################################### ######################################################################
# rustc-H-targets # rustc-H-targets
# #