bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Stop using the trigram of heaven as a hamburger button

Browse source 
It doesn't look quite right, because the lines are too far apart,
and it's not going to be announced by screenreaders as a menu button,
since that's not what the symbol means.

This adds a real tooltip and uses a better drawing of the icon.
This commit is contained in:
Michael Howell 2023-12-18 13:30:47 -07:00
parent bd14fb68da
commit c3e29ea5e9
6 changed files with 25 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/rustdoc-gui/sidebar-source-code-display.goml
View file

@ -130,7 +130,7 @@ call-function: ("check-colors", {
set-window-size: (500, 700)
reload:
// Waiting for the sidebar to be displayed...
wait-for-css: ("#src-sidebar", {"position": "sticky", "left": "0"})
wait-for-css: (".src .sidebar > *", {"visibility": "visible"})
// We now check it takes the full size of the display.
assert-property: ("body", {"clientWidth": "500", "clientHeight": "700"})
@ -138,7 +138,7 @@ assert-property: (".sidebar", {"clientWidth": "500", "clientHeight": "700"})
// We now check that the scroll position is kept when opening the sidebar.
click: "#sidebar-button"
wait-for-css: (".sidebar", {"position": "absolute", "left": "-1000px"})
wait-for-css: (".src .sidebar > *", {"visibility": "hidden"})
// We scroll to line 117 to change the scroll position.
scroll-to: '//*[@id="117"]'
assert-window-property: {"pageYOffset": "2516"}