bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Fix trait solver overflow with non_local_definitions lint

Browse source
This commit is contained in:
Urgau 2024-04-07 16:53:54 +02:00
parent 033becf83c
commit c2e2245fd8
3 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
compiler/rustc_lint/src/non_local_def.rs
View file

@ -265,7 +265,19 @@ fn impl_trait_ref_has_enough_non_local_candidates<'tcx>(
binder: EarlyBinder<TraitRef<'tcx>>,
mut did_has_local_parent: impl FnMut(DefId) -> bool,
) -> bool {
let infcx = tcx.infer_ctxt().build();
let infcx = tcx
.infer_ctxt()
// We use the new trait solver since the obligation we are trying to
// prove here may overflow and those are fatal in the old trait solver.
// Which is unacceptable for a lint.
//
// Thanksfully the part we use here are very similar to the
// new-trait-solver-as-coherence, which is in stabilization.
//
// https://github.com/rust-lang/rust/issues/123573
.with_next_trait_solver(true)
.build();
let trait_ref = binder.instantiate(tcx, infcx.fresh_args_for_item(infer_span, trait_def_id));
let trait_ref = trait_ref.fold_with(&mut ReplaceLocalTypesWithInfer {