bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #93763 - jsha:re-space-empty-impls, r=GuillaumeGomez

Browse source 
rustdoc: fix spacing of non-toggled impl blocks

We [recently removed the "up here" arrows on item-infos](https://github.com/rust-lang/rust/pull/92651), and adjusted
vertical spacing so that even without the arrow, it would be visually
clear which item the item-info belonged to. The new CSS styles for
vertical spacing only applied to toggles, though. This missed
non-toggled impl blocks - for instance, those without any methods, like
https://doc.rust-lang.org/nightly/std/marker/trait.Send.html#implementors.
The result was lists of implementors that were spaced too closely. This
PR fixes the spacing by making it apply to non-toggled impl blocks as
well.

This also fixes an issue where item-infos were displayed too far below
their items. That was a result of display: table on .item-info .stab.
Changed that to display: inline-block.

Demo: https://rustdoc.crud.net/jsha/re-space-empty-impls/std/marker/trait.Send.html

Before:

<img width=300 src="https://user-images.githubusercontent.com/220205/152954394-ec0b80e7-2573-4f06-9d7a-7b10b8ceac60.png">

After:

<img width=300 src="https://user-images.githubusercontent.com/220205/152954228-abac1d30-a76d-4ab1-89ec-ef7549fe8c9c.png">

r? `@GuillaumeGomez`
This commit is contained in:
bors 2022-02-13 09:41:41 +00:00
commit c26fbf857f
5 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/librustdoc/html/static/css/rustdoc.css
View file

@ -1041,7 +1041,7 @@ body.blur > :not(#help) {
}
.item-info .stab {
display: table;
display: inline-block;
}
.stab {
padding: 3px;
@ -2018,7 +2018,8 @@ details.rustdoc-toggle[open] > summary.hideme::after {
}
.method-toggle summary,
.implementors-toggle summary {
.implementors-toggle summary,
.impl {
margin-bottom: 0.75em;
}