Auto merge of #60352 - Centril:const-incomplete-features, r=oli-obk
Float 'incomplete_features' out to a const for visibility Float `let incomplete_features` out to a `const INCOMPLETE_FEATURES` and colocate near `active` features so that it is easier to find and edit. r? @oli-obk (use rollup)
This commit is contained in:
commit
bdfdbcd44d
1 changed files with 9 additions and 6 deletions
|
@ -477,6 +477,14 @@ declare_features! (
|
||||||
(active, c_variadic, "1.34.0", Some(44930), None),
|
(active, c_variadic, "1.34.0", Some(44930), None),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
// Some features are known to be incomplete and using them is likely to have
|
||||||
|
// unanticipated results, such as compiler crashes. We warn the user about these
|
||||||
|
// to alert them.
|
||||||
|
const INCOMPLETE_FEATURES: &[&str] = &[
|
||||||
|
"generic_associated_types",
|
||||||
|
"const_generics"
|
||||||
|
];
|
||||||
|
|
||||||
declare_features! (
|
declare_features! (
|
||||||
(removed, import_shadowing, "1.0.0", None, None, None),
|
(removed, import_shadowing, "1.0.0", None, None, None),
|
||||||
(removed, managed_boxes, "1.0.0", None, None, None),
|
(removed, managed_boxes, "1.0.0", None, None, None),
|
||||||
|
@ -2150,11 +2158,6 @@ pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute],
|
||||||
err.emit();
|
err.emit();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Some features are known to be incomplete and using them is likely to have
|
|
||||||
// unanticipated results, such as compiler crashes. We warn the user about these
|
|
||||||
// to alert them.
|
|
||||||
let incomplete_features = ["generic_associated_types", "const_generics"];
|
|
||||||
|
|
||||||
let mut features = Features::new();
|
let mut features = Features::new();
|
||||||
let mut edition_enabled_features = FxHashMap::default();
|
let mut edition_enabled_features = FxHashMap::default();
|
||||||
|
|
||||||
|
@ -2193,7 +2196,7 @@ pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute],
|
||||||
}
|
}
|
||||||
|
|
||||||
let name = mi.name_or_empty();
|
let name = mi.name_or_empty();
|
||||||
if incomplete_features.iter().any(|f| name == *f) {
|
if INCOMPLETE_FEATURES.iter().any(|f| name == *f) {
|
||||||
span_handler.struct_span_warn(
|
span_handler.struct_span_warn(
|
||||||
mi.span(),
|
mi.span(),
|
||||||
&format!(
|
&format!(
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue