bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Don't call walk_ functions directly if there is an equivalent visit_ method.

Browse source
This commit is contained in:
Guillaume Gomez 2024-01-24 17:33:33 +01:00
parent 366d112fa6
commit bdc9ce0d95
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_ast/src/visit.rs
View file

@ -375,11 +375,11 @@ pub fn walk_item<'a, V: Visitor<'a>>(visitor: &mut V, item: &'a Item) {
} }
ItemKind::MacCall(mac) => visitor.visit_mac_call(mac), ItemKind::MacCall(mac) => visitor.visit_mac_call(mac),
ItemKind::MacroDef(ts) => visitor.visit_mac_def(ts, item.id), ItemKind::MacroDef(ts) => visitor.visit_mac_def(ts, item.id),
ItemKind::Delegation(box Delegation { id: _, qself, path, body }) => { ItemKind::Delegation(box Delegation { id, qself, path, body }) => {
if let Some(qself) = qself { if let Some(qself) = qself {
visitor.visit_ty(&qself.ty); visitor.visit_ty(&qself.ty);
} }
walk_path(visitor, path); visitor.visit_path(path, *id);
if let Some(body) = body { if let Some(body) = body {
visitor.visit_block(body); visitor.visit_block(body);
} }
@ -502,7 +502,7 @@ where
} }
GenericArgs::Parenthesized(data) => { GenericArgs::Parenthesized(data) => {
walk_list!(visitor, visit_ty, &data.inputs); walk_list!(visitor, visit_ty, &data.inputs);
walk_fn_ret_ty(visitor, &data.output); visitor.visit_fn_ret_ty(&data.output);
} }
} }
} }
@ -713,11 +713,11 @@ pub fn walk_assoc_item<'a, V: Visitor<'a>>(visitor: &mut V, item: &'a AssocItem,
AssocItemKind::MacCall(mac) => { AssocItemKind::MacCall(mac) => {
visitor.visit_mac_call(mac); visitor.visit_mac_call(mac);
} }
AssocItemKind::Delegation(box Delegation { id: _, qself, path, body }) => { AssocItemKind::Delegation(box Delegation { id, qself, path, body }) => {
if let Some(qself) = qself { if let Some(qself) = qself {
visitor.visit_ty(&qself.ty); visitor.visit_ty(&qself.ty);
} }
walk_path(visitor, path); visitor.visit_path(path, *id);
if let Some(body) = body { if let Some(body) = body {
visitor.visit_block(body); visitor.visit_block(body);
} }