bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

implements issue #2356

Browse source
This commit is contained in:
Vincent Belliard 2012-08-22 20:40:42 +02:00
parent 6277046fa0
commit bdbedb9d35
1 changed files with 56 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

60
src/rustc/middle/resolve3.rs
View file

@ -4069,6 +4069,47 @@ struct Resolver {
} }
} }
fn name_exists_in_scope_class(name: &str) -> bool {
let mut i = self.type_ribs.len();
while i != 0 {
i -= 1;
let rib = self.type_ribs.get_elt(i);
match rib.kind {
MethodRibKind(node_id, _) =>
for vec::each(self.crate.node.module.items) |item| {
if item.id == node_id {
match item.node {
item_class(class_def, _) => {
for vec::each(class_def.fields) |field| {
match field.node.kind {
syntax::ast::unnamed_field
=> {},
syntax::ast::named_field(ident, _, _)
=> {
if str::eq_slice(self.session.str_of(ident),
name) {
return true
}
}
}
}
for vec::each(class_def.methods) |method| {
if str::eq_slice(self.session.str_of(method.ident),
name) {
return true
}
}
}
_ => {}
}
}
},
_ => {}
}
}
return false;
}
fn resolve_expr(expr: @expr, visitor: ResolveVisitor) { fn resolve_expr(expr: @expr, visitor: ResolveVisitor) {
// First, record candidate traits for this expression if it could // First, record candidate traits for this expression if it could
// result in the invocation of a method call. // result in the invocation of a method call.
@ -4093,12 +4134,21 @@ struct Resolver {
self.record_def(expr.id, def); self.record_def(expr.id, def);
} }
none => { none => {
self.session.span_err( let wrong_name =
expr.span,
fmt!("unresolved name: %s",
connect(path.idents.map( connect(path.idents.map(
|x| self.session.str_of(x)), |x| self.session.str_of(x)), ~"::") ;
~"::"))); if self.name_exists_in_scope_class(wrong_name) {
self.session.span_err(expr.span,
fmt!("unresolved name: %s. \
Did you mean: self.%s",
wrong_name,
wrong_name));
}
else {
self.session.span_err(expr.span,
fmt!("unresolved name: %s",
wrong_name));
}
} }
} }