bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

call emit_metadata only when metadata_kind is None

Browse source
This commit is contained in:
Yoshiki Matsuda 2022-04-28 10:27:38 +09:00
parent e7f95ace08
commit bb75c4b46a
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_metadata/src/fs.rs
View file

@ -69,9 +69,13 @@ pub fn encode_and_write_metadata(
let metadata_tmpdir = MaybeTempDir::new(metadata_tmpdir, tcx.sess.opts.cg.save_temps); let metadata_tmpdir = MaybeTempDir::new(metadata_tmpdir, tcx.sess.opts.cg.save_temps);
let metadata_filename = metadata_tmpdir.as_ref().join(METADATA_FILENAME); let metadata_filename = metadata_tmpdir.as_ref().join(METADATA_FILENAME);
let metadata = match metadata_kind { let metadata = match metadata_kind {
MetadataKind::None => EncodedMetadata::new(), MetadataKind::None => {
let metadata = EncodedMetadata::new();
let _ = emit_metadata(tcx.sess, metadata.raw_data(), &metadata_tmpdir);
metadata
}
MetadataKind::Uncompressed | MetadataKind::Compressed => { MetadataKind::Uncompressed | MetadataKind::Compressed => {
encode_metadata(tcx, metadata_filename) encode_metadata(tcx, &metadata_filename)
} }
}; };
@ -79,7 +83,6 @@ pub fn encode_and_write_metadata(
let need_metadata_file = tcx.sess.opts.output_types.contains_key(&OutputType::Metadata); let need_metadata_file = tcx.sess.opts.output_types.contains_key(&OutputType::Metadata);
if need_metadata_file { if need_metadata_file {
let metadata_filename = emit_metadata(tcx.sess, metadata.raw_data(), &metadata_tmpdir);
if let Err(e) = non_durable_rename(&metadata_filename, &out_filename) { if let Err(e) = non_durable_rename(&metadata_filename, &out_filename) {
tcx.sess.fatal(&format!("failed to write {}: {}", out_filename.display(), e)); tcx.sess.fatal(&format!("failed to write {}: {}", out_filename.display(), e));
} }