bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Consider lvalues of field and index as possibly temporary places

Browse source
This commit is contained in:
Michael Goulet 2025-02-23 01:09:51 +00:00
parent 2797936f6d
commit bad8e98c7d
5 changed files with 46 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_lint/src/if_let_rescope.rs
View file

@ -436,6 +436,14 @@ impl<'tcx> Visitor<'tcx> for FindSignificantDropper<'_, 'tcx> {
self.check_promoted_temp_with_drop(expr)?;
intravisit::walk_expr(self, expr)
}
// `(Drop, ()).1` introduces a temporary and then moves out of
// part of it, therefore we should check it for temporaries.
// FIXME: This may have false positives if we move the part
// that actually has drop, but oh well.
hir::ExprKind::Index(expr, _, _) | hir::ExprKind::Field(expr, _) => {
self.check_promoted_temp_with_drop(expr)?;
intravisit::walk_expr(self, expr)
}
// If always introduces a temporary terminating scope for its cond and arms,
// so don't visit them.
hir::ExprKind::If(..) => ControlFlow::Continue(()),