bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #107880 - jieyouxu:issue-107563, r=petrochenkov

Browse source 
Lint ambiguous glob re-exports

Attempts to fix #107563.

We currently already emit errors for ambiguous re-exports when two names are re-exported *specifically*, i.e. not from glob exports. This PR attempts to emit deny-by-default lints for ambiguous glob re-exports.
This commit is contained in:
Matthias Krüger 2023-03-23 19:55:43 +01:00 • committed by GitHub
commit bacf059f57
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 228 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_lint/src/context.rs
View file

@ -910,6 +910,10 @@ pub trait LintContext: Sized {
Applicability::MachineApplicable,
);
}
BuiltinLintDiagnostics::AmbiguousGlobReexports { name, namespace, first_reexport_span, duplicate_reexport_span } => {
db.span_label(first_reexport_span, format!("the name `{}` in the {} namespace is first re-exported here", name, namespace));
db.span_label(duplicate_reexport_span, format!("but the name `{}` in the {} namespace is also re-exported here", name, namespace));
}
}
// Rewrap `db`, and pass control to the user.
decorate(db)