bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Remove redundant Dominators::start_node field

Browse source
This commit is contained in:
Tomasz Miąsko 2023-10-05 00:00:00 +00:00
parent a8ec7ddf0e
commit ba694e301c
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_data_structures/src/graph/dominators/mod.rs
View file

@ -245,7 +245,7 @@ pub fn dominators<G: ControlFlowGraph>(graph: &G) -> Dominators<G::Node> {
let time = compute_access_time(start_node, &immediate_dominators); let time = compute_access_time(start_node, &immediate_dominators);
Dominators { start_node, post_order_rank, immediate_dominators, time } Dominators { post_order_rank, immediate_dominators, time }
} }
/// Evaluate the link-eval virtual forest, providing the currently minimum semi /// Evaluate the link-eval virtual forest, providing the currently minimum semi
@ -311,7 +311,6 @@ fn compress(
/// Tracks the list of dominators for each node. /// Tracks the list of dominators for each node.
#[derive(Clone, Debug)] #[derive(Clone, Debug)]
pub struct Dominators<N: Idx> { pub struct Dominators<N: Idx> {
start_node: N,
post_order_rank: IndexVec<N, usize>, post_order_rank: IndexVec<N, usize>,
// Even though we track only the immediate dominator of each node, it's // Even though we track only the immediate dominator of each node, it's
// possible to get its full list of dominators by looking up the dominator // possible to get its full list of dominators by looking up the dominator
@ -323,7 +322,7 @@ pub struct Dominators<N: Idx> {
impl<Node: Idx> Dominators<Node> { impl<Node: Idx> Dominators<Node> {
/// Returns true if node is reachable from the start node. /// Returns true if node is reachable from the start node.
pub fn is_reachable(&self, node: Node) -> bool { pub fn is_reachable(&self, node: Node) -> bool {
node == self.start_node || self.immediate_dominators[node].is_some() self.time[node].start != 0
} }
/// Returns the immediate dominator of node, if any. /// Returns the immediate dominator of node, if any.