bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Lint against misplaced where-clauses on assoc tys in traits

Browse source
This commit is contained in:
León Orell Valerian Liehr 2023-07-11 01:11:21 +02:00
parent 71f71a5397
commit b809207dec
No known key found for this signature in database
GPG key ID: D17A07215F68E713
10 changed files with 81 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

31
compiler/rustc_ast_passes/src/ast_validation.rs
View file

@ -1300,14 +1300,7 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
});
}
}
AssocItemKind::Type(box TyAlias {
generics,
where_clauses,
where_predicates_split,
bounds,
ty,
..
}) => {
AssocItemKind::Type(box TyAlias { bounds, ty, .. }) => {
if ty.is_none() {
self.session.emit_err(errors::AssocTypeWithoutBody {
span: item.span,
@ -1315,18 +1308,26 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
});
}
self.check_type_no_bounds(bounds, "`impl`s");
if ty.is_some() {
self.check_gat_where(
item.id,
generics.where_clause.predicates.split_at(*where_predicates_split).0,
*where_clauses,
);
}
}
_ => {}
}
}
if let AssocItemKind::Type(box TyAlias {
generics,
where_clauses,
where_predicates_split,
ty: Some(_),
..
}) = &item.kind
{
self.check_gat_where(
item.id,
generics.where_clause.predicates.split_at(*where_predicates_split).0,
*where_clauses,
);
}
if ctxt == AssocCtxt::Trait || self.in_trait_impl {
self.visibility_not_permitted(&item.vis, errors::VisibilityNotPermittedNote::TraitImpl);
if let AssocItemKind::Fn(box Fn { sig, .. }) = &item.kind {