bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: disable forbidden #[target_feature] check

Browse source
This commit is contained in:
Ralf Jung 2025-02-25 20:26:12 +01:00
parent e0be1a0262
commit b6f2240000
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/rustc_codegen_ssa/src/target_features.rs
View file

@ -87,7 +87,10 @@ pub(crate) fn from_target_feature_attr(
// But ensure the ABI does not forbid enabling this. // But ensure the ABI does not forbid enabling this.
// Here we do assume that LLVM doesn't add even more implied features // Here we do assume that LLVM doesn't add even more implied features
// we don't know about, at least no features that would have ABI effects! // we don't know about, at least no features that would have ABI effects!
if abi_feature_constraints.incompatible.contains(&name.as_str()) { // We skip this check in rustdoc, like we skip all target feature related checks.
if !tcx.sess.opts.actually_rustdoc
&& abi_feature_constraints.incompatible.contains(&name.as_str())
{
tcx.dcx().emit_err(errors::ForbiddenTargetFeatureAttr { tcx.dcx().emit_err(errors::ForbiddenTargetFeatureAttr {
span: item.span(), span: item.span(),
feature: name.as_str(), feature: name.as_str(),
@ -142,8 +145,11 @@ pub(crate) fn provide(providers: &mut Providers) {
rust_target_features: |tcx, cnum| { rust_target_features: |tcx, cnum| {
assert_eq!(cnum, LOCAL_CRATE); assert_eq!(cnum, LOCAL_CRATE);
if tcx.sess.opts.actually_rustdoc { if tcx.sess.opts.actually_rustdoc {
// rustdoc needs to be able to document functions that use all the features, so // HACK: rustdoc would like to pretend that we have all the target features, so we
// whitelist them all // have to merge all the lists into one. The result has a "random" stability
// (depending on the order in which we consider features); all places that check
// target stability are expected to check `actually_rustdoc` and do nothing when
// that is set.
rustc_target::target_features::all_rust_features() rustc_target::target_features::all_rust_features()
.map(|(a, b)| (a.to_string(), b)) .map(|(a, b)| (a.to_string(), b))
.collect() .collect()