bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Wesley Wiser <wwiser@gmail.com>
This commit is contained in:
Rich Kadel 2020-11-24 18:34:10 -08:00 • committed by GitHub
parent 51268d2735
commit b5fef37d23
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs
View file

@ -169,7 +169,7 @@ impl CoverageMapGenerator {
); );
// Create the coverage data header (Note, fields 0 and 2 are now always zero, // Create the coverage data header (Note, fields 0 and 2 are now always zero,
// as of `llvm::coverage::CovMapVersion::Version4`. // as of `llvm::coverage::CovMapVersion::Version4`.)
let zero_was_n_records_val = cx.const_u32(0); let zero_was_n_records_val = cx.const_u32(0);
let filenames_size_val = cx.const_u32(filenames_size as u32); let filenames_size_val = cx.const_u32(filenames_size as u32);
let zero_was_coverage_size_val = cx.const_u32(0); let zero_was_coverage_size_val = cx.const_u32(0);

2
src/test/run-make-fulldeps/coverage-llvmir-base/Makefile
View file

@ -56,7 +56,7 @@ else
-DINSTR_PROF_ORDERFILE='$(DATA_SECTION_PREFIX)__llvm_orderfile' -DINSTR_PROF_ORDERFILE='$(DATA_SECTION_PREFIX)__llvm_orderfile'
endif endif
ifeq ($(LLVM_VERSION_11_PLUS),false) ifeq ($(LLVM_VERSION_11_PLUS),true)
all: test_llvm_ir all: test_llvm_ir
else else
$(info Rust option `-Z instrument-coverage` requires LLVM 11 or higher. Test skipped.) $(info Rust option `-Z instrument-coverage` requires LLVM 11 or higher. Test skipped.)