bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Use verbose style when suggesting changing const with let

Browse source
This commit is contained in:
Esteban Küber 2024-07-05 19:32:17 +00:00
parent bcf1f6db45
commit b56dc8ee90
20 changed files with 153 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_resolve/src/diagnostics.rs
View file

@ -836,11 +836,12 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
let ((with, with_label), without) = match sp {
Some(sp) if !self.tcx.sess.source_map().is_multiline(sp) => {
let sp = sp.with_lo(BytePos(sp.lo().0 - (current.len() as u32)));
let sp = sp
.with_lo(BytePos(sp.lo().0 - (current.len() as u32)))
.until(ident.span);
(
(Some(errs::AttemptToUseNonConstantValueInConstantWithSuggestion {
span: sp,
ident,
suggestion,
current,
}), Some(errs::AttemptToUseNonConstantValueInConstantLabelWithSuggestion {span})),

4
compiler/rustc_resolve/src/errors.rs
View file

@ -242,13 +242,13 @@ pub(crate) struct AttemptToUseNonConstantValueInConstant<'a> {
#[derive(Subdiagnostic)]
#[suggestion(
resolve_attempt_to_use_non_constant_value_in_constant_with_suggestion,
code = "{suggestion} {ident}",
code = "{suggestion} ",
style = "verbose",
applicability = "maybe-incorrect"
)]
pub(crate) struct AttemptToUseNonConstantValueInConstantWithSuggestion<'a> {
#[primary_span]
pub(crate) span: Span,
pub(crate) ident: Ident,
pub(crate) suggestion: &'a str,
pub(crate) current: &'a str,
}