bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Remove duplicates in rustdoc

Browse source
This commit is contained in:
Guillaume Gomez 2017-08-18 00:08:12 +02:00
parent dd39ecf368
commit b4a32434c0
2 changed files with 35 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

31
src/librustdoc/html/render.rs
View file

@ -1764,6 +1764,37 @@ fn item_module(w: &mut fmt::Formatter, cx: &Context,
}
indices.sort_by(|&i1, &i2| cmp(&items[i1], &items[i2], i1, i2));
// This call is to remove reexport duplicates in cases such as:
//
// ```
// pub mod foo {
// pub mod bar {
// pub trait Double { fn foo(); }
// }
// }
//
// pub use foo::bar::*;
// pub use foo::*;
// ```
//
// `Double` will appear twice in the generated docs.
//
// FIXME: This code is quite ugly and could be improved. Small issue: DefId
// can be identical even if the elements are different (mostly in imports).
// So in case this is an import, we keep everything by adding a "unique id"
// (which is the position in the vector).
indices.dedup_by_key(|i| (items[*i].def_id,
if items[*i].name.as_ref().is_some() {
Some(full_path(cx, &items[*i]).clone())
} else {
None
},
items[*i].type_(),
if items[*i].is_import() {
*i
} else {
0
}));
debug!("{:?}", indices);
let mut curty = None;