bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Break fold's circular reference during unwinding

Browse source 
This converts the AST fold into a resource that breaks it's own circular
reference (just a temporary workaround until GC), so that failure during fold
will unwind correctly.

Issue #936
This commit is contained in:
Brian Anderson 2011-09-19 15:30:58 -07:00
parent 939a9dd738
commit b1bf9ef5ae
6 changed files with 7 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/comp/syntax/fold.rs
View file

@ -563,8 +563,13 @@ fn dummy_out(a: ast_fold) {
new_span: noop_span};
}
// FIXME: Fold has a circular reference that has to be broken. With GC this
// can go away
resource foldres(f: ast_fold) {
dummy_out(f);
}
fn make_fold(afp: ast_fold_precursor) -> ast_fold {
fn make_fold(afp: ast_fold_precursor) -> @foldres {
let result: ast_fold =
@mutable {fold_crate: nf_crate_dummy,
fold_crate_directive: nf_crate_directive_dummy,
@ -699,7 +704,7 @@ fn make_fold(afp: ast_fold_precursor) -> ast_fold {
map_exprs: afp.map_exprs,
new_id: afp.new_id,
new_span: afp.new_span};
ret result;
ret @foldres(result);
}