bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Suggest deref on comparison binop RHS even if type is not Copy

Browse source
This commit is contained in:
Michael Goulet 2023-04-19 16:47:06 +00:00
parent de96f3d873
commit b0a7d6e4b7
3 changed files with 29 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_hir_typeck/src/demand.rs
View file

@ -1508,6 +1508,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
// FIXME(compiler-errors): We can actually do this if the checked_ty is
// `steps` layers of boxes, not just one, but this is easier and most likely.
|| (checked_ty.is_box() && steps == 1)
// We can always deref a binop that takes its arguments by ref.
|| matches!(
self.tcx.hir().get_parent(expr.hir_id),
hir::Node::Expr(hir::Expr { kind: hir::ExprKind::Binary(op, ..), .. })
if !op.node.is_by_value()
)
{
let deref_kind = if checked_ty.is_box() {
"unboxing the value"