bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Reduce double errors for invalid let expressions

Browse source 
Previously some invalid let expressions would result in both a feature
error and a parsing error. Avoid this and ensure that we only emit the
parsing error when this happens.
This commit is contained in:
Matthew Jasper 2023-09-11 16:16:59 +00:00
parent 2d7a5f528c
commit b011a0a13b
7 changed files with 1249 additions and 140 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_parse/src/parser/expr.rs
View file

@ -2485,9 +2485,6 @@ impl<'a> Parser<'a> {
}
let expr = self.parse_expr_assoc_with(1 + prec_let_scrutinee_needs_par(), None.into())?;
let span = lo.to(expr.span);
if is_recovered.is_none() {
self.sess.gated_spans.gate(sym::let_chains, span);
}
Ok(self.mk_expr(span, ExprKind::Let(pat, expr, span, is_recovered)))
}
@ -3460,6 +3457,8 @@ impl MutVisitor for CondChecker<'_> {
.sess
.emit_err(errors::ExpectedExpressionFoundLet { span, reason }),
);
} else {
self.parser.sess.gated_spans.gate(sym::let_chains, span);
}
}
ExprKind::Binary(Spanned { node: BinOpKind::And, .. }, _, _) => {