Use correct edition for panic in [debug_]assert!() etc.
This commit is contained in:
parent
ca8078d7b2
commit
afe5335b97
4 changed files with 23 additions and 4 deletions
|
@ -1,10 +1,10 @@
|
||||||
use rustc_errors::{Applicability, DiagnosticBuilder};
|
use crate::panic::use_panic_2021;
|
||||||
|
|
||||||
use rustc_ast::ptr::P;
|
use rustc_ast::ptr::P;
|
||||||
use rustc_ast::token;
|
use rustc_ast::token;
|
||||||
use rustc_ast::tokenstream::{DelimSpan, TokenStream};
|
use rustc_ast::tokenstream::{DelimSpan, TokenStream};
|
||||||
use rustc_ast::{self as ast, *};
|
use rustc_ast::{self as ast, *};
|
||||||
use rustc_ast_pretty::pprust;
|
use rustc_ast_pretty::pprust;
|
||||||
|
use rustc_errors::{Applicability, DiagnosticBuilder};
|
||||||
use rustc_expand::base::*;
|
use rustc_expand::base::*;
|
||||||
use rustc_parse::parser::Parser;
|
use rustc_parse::parser::Parser;
|
||||||
use rustc_span::symbol::{sym, Ident, Symbol};
|
use rustc_span::symbol::{sym, Ident, Symbol};
|
||||||
|
@ -28,7 +28,7 @@ pub fn expand_assert<'cx>(
|
||||||
let sp = cx.with_call_site_ctxt(span);
|
let sp = cx.with_call_site_ctxt(span);
|
||||||
|
|
||||||
let panic_call = if let Some(tokens) = custom_message {
|
let panic_call = if let Some(tokens) = custom_message {
|
||||||
let path = if span.rust_2021() {
|
let path = if use_panic_2021(span) {
|
||||||
// On edition 2021, we always call `$crate::panic::panic_2021!()`.
|
// On edition 2021, we always call `$crate::panic::panic_2021!()`.
|
||||||
Path {
|
Path {
|
||||||
span: sp,
|
span: sp,
|
||||||
|
|
|
@ -2,6 +2,7 @@ use rustc_ast::ptr::P;
|
||||||
use rustc_ast::tokenstream::{DelimSpan, TokenStream};
|
use rustc_ast::tokenstream::{DelimSpan, TokenStream};
|
||||||
use rustc_ast::*;
|
use rustc_ast::*;
|
||||||
use rustc_expand::base::*;
|
use rustc_expand::base::*;
|
||||||
|
use rustc_span::edition::Edition;
|
||||||
use rustc_span::symbol::sym;
|
use rustc_span::symbol::sym;
|
||||||
use rustc_span::Span;
|
use rustc_span::Span;
|
||||||
|
|
||||||
|
@ -19,7 +20,7 @@ pub fn expand_panic<'cx>(
|
||||||
sp: Span,
|
sp: Span,
|
||||||
tts: TokenStream,
|
tts: TokenStream,
|
||||||
) -> Box<dyn MacResult + 'cx> {
|
) -> Box<dyn MacResult + 'cx> {
|
||||||
let panic = if sp.rust_2021() { sym::panic_2021 } else { sym::panic_2015 };
|
let panic = if use_panic_2021(sp) { sym::panic_2021 } else { sym::panic_2015 };
|
||||||
|
|
||||||
let sp = cx.with_call_site_ctxt(sp);
|
let sp = cx.with_call_site_ctxt(sp);
|
||||||
|
|
||||||
|
@ -46,3 +47,19 @@ pub fn expand_panic<'cx>(
|
||||||
),
|
),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
pub fn use_panic_2021(mut span: Span) -> bool {
|
||||||
|
// To determine the editon, we check the first span up the expansion
|
||||||
|
// stack that does not have #[allow_internal_unstable(edition_panic)].
|
||||||
|
// (To avoid using the edition of e.g. the assert!() or debug_assert!() definition.)
|
||||||
|
loop {
|
||||||
|
let expn = span.ctxt().outer_expn_data();
|
||||||
|
if let Some(features) = expn.allow_internal_unstable {
|
||||||
|
if features.iter().any(|&f| f == sym::edition_panic) {
|
||||||
|
span = expn.call_site;
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
break expn.edition >= Edition::Edition2021;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
|
@ -568,6 +568,7 @@ symbols! {
|
||||||
dyn_metadata,
|
dyn_metadata,
|
||||||
dyn_trait,
|
dyn_trait,
|
||||||
edition_macro_pats,
|
edition_macro_pats,
|
||||||
|
edition_panic,
|
||||||
eh_catch_typeinfo,
|
eh_catch_typeinfo,
|
||||||
eh_personality,
|
eh_personality,
|
||||||
emit_enum,
|
emit_enum,
|
||||||
|
|
|
@ -210,6 +210,7 @@ pub macro assert_matches {
|
||||||
#[macro_export]
|
#[macro_export]
|
||||||
#[stable(feature = "rust1", since = "1.0.0")]
|
#[stable(feature = "rust1", since = "1.0.0")]
|
||||||
#[rustc_diagnostic_item = "debug_assert_macro"]
|
#[rustc_diagnostic_item = "debug_assert_macro"]
|
||||||
|
#[allow_internal_unstable(edition_panic)]
|
||||||
macro_rules! debug_assert {
|
macro_rules! debug_assert {
|
||||||
($($arg:tt)*) => (if $crate::cfg!(debug_assertions) { $crate::assert!($($arg)*); })
|
($($arg:tt)*) => (if $crate::cfg!(debug_assertions) { $crate::assert!($($arg)*); })
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue