bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #33979 - retep998:why-the-long-face, r=alexcrichton

Browse source 
Attempt to diagnose #33844

https://github.com/rust-lang/rust/issues/33844 is a spurious failure that causes builds to fail due to the linker command sometimes failing with error 206, which means that the command is too long. This PR makes rustc print out the linker arguments in that case so the reason for it being so long can be diagnosed and hopefully fixed.

r? @alexcrichton
This commit is contained in:
bors 2016-05-31 18:49:48 -07:00
commit ad5fbaf57c
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/librustc_trans/back/link.rs
View file

@ -692,7 +692,11 @@ fn link_natively(sess: &Session,
info!("linker stdout:\n{}", escape_string(&prog.stdout[..])); info!("linker stdout:\n{}", escape_string(&prog.stdout[..]));
}, },
Err(e) => { Err(e) => {
sess.fatal(&format!("could not exec the linker `{}`: {}", pname, e)); // Trying to diagnose https://github.com/rust-lang/rust/issues/33844
sess.struct_err(&format!("could not exec the linker `{}`: {}", pname, e))
.note(&format!("{:?}", &cmd))
.emit();
sess.abort_if_errors();
} }
} }