bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Clarify comments about doc comments in macros.

Browse source
This commit is contained in:
Nicholas Nethercote 2022-03-29 13:27:59 +11:00
parent 2b60cc081b
commit ac3d8ce1c6
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
compiler/rustc_expand/src/mbe/macro_parser.rs
View file

@ -517,7 +517,12 @@ impl<'tt> TtParser<'tt> {
TokenTree::Token(t) => { TokenTree::Token(t) => {
// If it's a doc comment, we just ignore it and move on to the next tt in // If it's a doc comment, we just ignore it and move on to the next tt in
// the matcher. If the token matches, we can just advance the parser. // the matcher. This is a bug, but #95267 showed that existing programs
// rely on this behaviour, and changing it would require some care and a
// transition period.
//
// If the token matches, we can just advance the parser.
//
// Otherwise, this match has failed, there is nothing to do, and hopefully // Otherwise, this match has failed, there is nothing to do, and hopefully
// another item in `cur_items` will match. // another item in `cur_items` will match.
if matches!(t, Token { kind: DocComment(..), .. }) { if matches!(t, Token { kind: DocComment(..), .. }) {

5
src/test/ui/macros/issue-95267.rs
View file

@ -1,7 +1,8 @@
// check-pass // check-pass
// This is a valid macro. Commit 4 in #95159 broke things such that it failed // The doc comment here is ignored. This is a bug, but #95267 showed that
// with a "missing tokens in macro arguments" error, as reported in #95267. // existing programs rely on this behaviour, and changing it would require some
// care and a transition period.
macro_rules! f { macro_rules! f {
( (
/// ab /// ab