Rollup merge of #90861 - 5225225:nonprinting-char, r=davidtwco
Print escaped string if char literal has multiple characters, but only one printable character Fixes #90857 I'm not sure about the error message here, it could get rather long and *maybe* using the names of characters would be better? That wouldn't help the length any, though.
This commit is contained in:
commit
ab958a7ab0
4 changed files with 54 additions and 1 deletions
|
@ -82,6 +82,33 @@ pub(crate) fn emit_unescape_error(
|
|||
Applicability::MachineApplicable,
|
||||
);
|
||||
}
|
||||
} else {
|
||||
let printable: Vec<char> = lit
|
||||
.chars()
|
||||
.filter(|&x| {
|
||||
unicode_width::UnicodeWidthChar::width(x).unwrap_or(0) != 0
|
||||
&& !x.is_whitespace()
|
||||
})
|
||||
.collect();
|
||||
|
||||
if let [ch] = printable.as_slice() {
|
||||
has_help = true;
|
||||
|
||||
handler.span_note(
|
||||
span,
|
||||
&format!(
|
||||
"there are non-printing characters, the full sequence is `{}`",
|
||||
lit.escape_default(),
|
||||
),
|
||||
);
|
||||
|
||||
handler.span_suggestion(
|
||||
span,
|
||||
"consider removing the non-printing characters",
|
||||
ch.to_string(),
|
||||
Applicability::MaybeIncorrect,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
if !has_help {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue