bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Only emit issues for build failures to supress spurious failures

Browse source
This commit is contained in:
Oliver Scherer 2018-12-19 16:37:16 +01:00
parent c485acb27c
commit ab5fc7fb5b
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/tools/publish_toolstate.py
View file

@ -115,17 +115,21 @@ def update_latest(
new = s.get(tool, old) new = s.get(tool, old)
status[os] = new status[os] = new
if new > old: if new > old:
# things got fixed or at least the status quo improved
changed = True changed = True
message += '🎉 {} on {}: {} → {} (cc {}, @rust-lang/infra).\n' \ message += '🎉 {} on {}: {} → {} (cc {}, @rust-lang/infra).\n' \
.format(tool, os, old, new, MAINTAINERS.get(tool)) .format(tool, os, old, new, MAINTAINERS.get(tool))
elif new < old: elif new < old:
# tests or builds are failing and were not failing before
changed = True changed = True
title = '💔 {} on {}: {} → {}' \ title = '💔 {} on {}: {} → {}' \
.format(tool, os, old, new) .format(tool, os, old, new)
message += '{} (cc {}, @rust-lang/infra).\n' \ message += '{} (cc {}, @rust-lang/infra).\n' \
.format(title, MAINTAINERS.get(tool)) .format(title, MAINTAINERS.get(tool))
failures += title # only create issues for build failures. Other failures can be spurious
failures += '\n' if new == 'build-fail':
failures += title
failures += '\n'
if failures != '': if failures != '':
issue(tool, MAINTAINERS.get(tool), relevant_pr_number, relevant_pr_user, failures) issue(tool, MAINTAINERS.get(tool), relevant_pr_number, relevant_pr_user, failures)
@ -151,6 +155,7 @@ if __name__ == '__main__':
save_message_to_path = sys.argv[3] save_message_to_path = sys.argv[3]
github_token = sys.argv[4] github_token = sys.argv[4]
# assume that PR authors are also owners of the repo where the branch lives
relevant_pr_match = re.search('Auto merge of #([0-9]+) - ([^:]+)', cur_commit_msg) relevant_pr_match = re.search('Auto merge of #([0-9]+) - ([^:]+)', cur_commit_msg)
if relevant_pr_match: if relevant_pr_match:
number = relevant_pr_match.group(1) number = relevant_pr_match.group(1)