bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

ast: Optimize list and value extraction primitives for attributes

Browse source 
It's not necessary to convert the whole attribute into a meta item to extract something specific
This commit is contained in:
Vadim Petrochenkov 2023-02-01 20:26:05 +04:00
parent 11d96b5930
commit a9c8a5c025
4 changed files with 90 additions and 76 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_passes/src/lib_features.rs
View file

@ -4,7 +4,7 @@
//! but are not declared in one single location (unlike lang features), which means we need to
//! collect them instead.
use rustc_ast::{Attribute, MetaItemKind};
use rustc_ast::Attribute;
use rustc_attr::{rust_version_symbol, VERSION_PLACEHOLDER};
use rustc_hir::intravisit::Visitor;
use rustc_middle::hir::nested_filter;
@ -42,8 +42,7 @@ impl<'tcx> LibFeatureCollector<'tcx> {
// Find a stability attribute: one of #[stable(…)], #[unstable(…)],
// #[rustc_const_stable(…)], #[rustc_const_unstable(…)] or #[rustc_default_body_unstable].
if let Some(stab_attr) = stab_attrs.iter().find(|stab_attr| attr.has_name(**stab_attr)) {
let meta_kind = attr.meta_kind();
if let Some(MetaItemKind::List(ref metas)) = meta_kind {
if let Some(metas) = attr.meta_item_list() {
let mut feature = None;
let mut since = None;
for meta in metas {