bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: Rename misleading function

Browse source 
- `is_associated` -> `is_type_alias`

`is_associated` is not a good name for what this is doing. If you look at
https://github.com/rust-lang/rust/pull/74489/files#diff-6a301d597807ee441a41e7237800563dR296,
is_associated() and as_assoc_kind() do completely different things, but
from the name it sounds like they're similar.
This commit is contained in:
Joshua Nelson 2020-07-18 16:48:59 -04:00
parent 9ed91f363a
commit a97d65d6e4
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/librustdoc/clean/types.rs
View file

@ -282,7 +282,7 @@ pub enum ItemEnum {
} }
impl ItemEnum { impl ItemEnum {
pub fn is_associated(&self) -> bool { pub fn is_type_alias(&self) -> bool {
match *self { match *self {
ItemEnum::TypedefItem(_, _) | ItemEnum::AssocTypeItem(_, _) => true, ItemEnum::TypedefItem(_, _) | ItemEnum::AssocTypeItem(_, _) => true,
_ => false, _ => false,

2
src/librustdoc/html/render/mod.rs
View file

@ -3612,7 +3612,7 @@ fn render_impl(
}; };
let (is_hidden, extra_class) = let (is_hidden, extra_class) =
if (trait_.is_none() || item.doc_value().is_some() || item.inner.is_associated()) if (trait_.is_none() || item.doc_value().is_some() || item.inner.is_type_alias())
&& !is_default_item && !is_default_item
{ {
(false, "") (false, "")