bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #80692 - Aaron1011:feature/query-result-debug, r=estebank

Browse source 
Enforce that query results implement Debug

Currently, we require that query keys implement `Debug`, but we do not do the same for query values. This can make incremental compilation bugs difficult to debug - there isn't a good place to print out the result loaded from disk.

This PR adds `Debug` bounds to several query-related functions, allowing us to debug-print the query value when an 'unstable fingerprint' error occurs. This required adding `#[derive(Debug)]` to a fairly large number of types - hopefully, this doesn't have much of an impact on compiler bootstrapping times.
This commit is contained in:
bors 2021-01-26 05:47:23 +00:00
commit a8f7075532
23 changed files with 46 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_feature/src/active.rs
View file

@ -36,7 +36,7 @@ macro_rules! declare_features {
),+];
/// A set of features to be used by later passes.
#[derive(Clone, Default)]
#[derive(Clone, Default, Debug)]
pub struct Features {
/// `#![feature]` attrs for language features, for error reporting.
pub declared_lang_features: Vec<(Symbol, Span, Option<Symbol>)>,