bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Properly static lib packaging

Browse source 
Fixes #18574
This commit is contained in:
Valerii Hiora 2014-11-07 19:12:43 +02:00
parent 223ca76439
commit a722f70207
2 changed files with 18 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/librustc/back/link.rs
View file

@ -734,7 +734,7 @@ fn link_staticlib(sess: &Session, obj_filename: &Path, out_filename: &Path) {
let mut all_native_libs = vec![]; let mut all_native_libs = vec![];
for &(cnum, ref path) in crates.iter() { for &(cnum, ref path) in crates.iter() {
let name = sess.cstore.get_crate_data(cnum).name.clone(); let ref name = sess.cstore.get_crate_data(cnum).name;
let p = match *path { let p = match *path {
Some(ref p) => p.clone(), None => { Some(ref p) => p.clone(), None => {
sess.err(format!("could not find rlib for: `{}`", sess.err(format!("could not find rlib for: `{}`",

27
src/librustc_back/archive.rs
View file

@ -183,7 +183,7 @@ impl<'a> ArchiveBuilder<'a> {
self.archive.slib_suffix.as_slice(), self.archive.slib_suffix.as_slice(),
self.archive.lib_search_paths.as_slice(), self.archive.lib_search_paths.as_slice(),
self.archive.handler); self.archive.handler);
self.add_archive(&location, name, []) self.add_archive(&location, name, |_| false)
} }
/// Adds all of the contents of the rlib at the specified path to this /// Adds all of the contents of the rlib at the specified path to this
@ -193,13 +193,20 @@ impl<'a> ArchiveBuilder<'a> {
/// then the object file also isn't added. /// then the object file also isn't added.
pub fn add_rlib(&mut self, rlib: &Path, name: &str, pub fn add_rlib(&mut self, rlib: &Path, name: &str,
lto: bool) -> io::IoResult<()> { lto: bool) -> io::IoResult<()> {
let object = format!("{}.o", name); // Ignoring obj file starting with the crate name
let bytecode = format!("{}.bytecode.deflate", name); // as simple comparison is not enough - there
let mut ignore = vec!(bytecode.as_slice(), METADATA_FILENAME); // might be also an extra name suffix
if lto { let obj_start = format!("{}", name);
ignore.push(object.as_slice()); let obj_start = obj_start.as_slice();
} // Ignoring all bytecode files, no matter of
self.add_archive(rlib, name, ignore.as_slice()) // name
let bc_ext = ".bytecode.deflate";
self.add_archive(rlib, name.as_slice(), |fname: &str| {
let skip_obj = lto && fname.starts_with(obj_start)
&& fname.ends_with(".o");
skip_obj || fname.ends_with(bc_ext) || fname == METADATA_FILENAME
})
} }
/// Adds an arbitrary file to this archive /// Adds an arbitrary file to this archive
@ -273,7 +280,7 @@ impl<'a> ArchiveBuilder<'a> {
} }
fn add_archive(&mut self, archive: &Path, name: &str, fn add_archive(&mut self, archive: &Path, name: &str,
skip: &[&str]) -> io::IoResult<()> { skip: |&str| -> bool) -> io::IoResult<()> {
let loc = TempDir::new("rsar").unwrap(); let loc = TempDir::new("rsar").unwrap();
// First, extract the contents of the archive to a temporary directory. // First, extract the contents of the archive to a temporary directory.
@ -295,7 +302,7 @@ impl<'a> ArchiveBuilder<'a> {
let files = try!(fs::readdir(loc.path())); let files = try!(fs::readdir(loc.path()));
for file in files.iter() { for file in files.iter() {
let filename = file.filename_str().unwrap(); let filename = file.filename_str().unwrap();
if skip.iter().any(|s| *s == filename) { continue } if skip(filename) { continue }
if filename.contains(".SYMDEF") { continue } if filename.contains(".SYMDEF") { continue }
let filename = format!("r-{}-{}", name, filename); let filename = format!("r-{}-{}", name, filename);