1
Fork 0

Addressed comments by @compiler-errors and @bjorn3

This commit is contained in:
Yuri Astrakhan 2022-03-30 17:04:46 -04:00
parent c9c6e22f4b
commit a6dd658254
10 changed files with 10 additions and 10 deletions

View file

@ -2646,7 +2646,7 @@ mod sig {
// Convert the result having "2 * precision" significant-bits back to the one // Convert the result having "2 * precision" significant-bits back to the one
// having "precision" significant-bits. First, move the radix point from // having "precision" significant-bits. First, move the radix point from
// position "2*precision - 1" to "precision - 1". The exponent need to be // poision "2*precision - 1" to "precision - 1". The exponent need to be
// adjusted by "2*precision - 1" - "precision - 1" = "precision". // adjusted by "2*precision - 1" - "precision - 1" = "precision".
*exp -= precision as ExpInt + 1; *exp -= precision as ExpInt + 1;

View file

@ -23,7 +23,7 @@
//! ss2 = explicit_slot 8 ; _4: (&&[u16],) size=8 align=8,8 //! ss2 = explicit_slot 8 ; _4: (&&[u16],) size=8 align=8,8
//! sig0 = (i64, i64, i64) system_v //! sig0 = (i64, i64, i64) system_v
//! sig1 = (i64, i64, i64) system_v //! sig1 = (i64, i64, i64) system_v
//! fn0 = collocated u0:6 sig1 ; Instance { def: Item(DefId(0/0:31 ~ example[8787]::{{impl}}[1]::call_mut[0])), substs: [ReErased, ReErased] } //! fn0 = colocated u0:6 sig1 ; Instance { def: Item(DefId(0/0:31 ~ example[8787]::{{impl}}[1]::call_mut[0])), substs: [ReErased, ReErased] }
//! //!
//! block0(v0: i64, v1: i64, v2: i64): //! block0(v0: i64, v1: i64, v2: i64):
//! v3 = stack_addr.i64 ss0 //! v3 = stack_addr.i64 ss0

View file

@ -125,7 +125,7 @@ fn compute_components<'tcx>(
// regionck more ways to prove that it holds. However, // regionck more ways to prove that it holds. However,
// regionck is not (at least currently) prepared to deal with // regionck is not (at least currently) prepared to deal with
// higher-ranked regions that may appear in the // higher-ranked regions that may appear in the
// trait-ref. Therefore, if we see any higher-rank regions, // trait-ref. Therefore, if we see any higher-ranked regions,
// we simply fallback to the most restrictive rule, which // we simply fallback to the most restrictive rule, which
// requires that `Pi: 'a` for all `i`. // requires that `Pi: 'a` for all `i`.
ty::Projection(ref data) => { ty::Projection(ref data) => {

View file

@ -243,7 +243,7 @@ impl<'me, 'tcx> LeakCheck<'me, 'tcx> {
// Update minimum universe of scc1. // Update minimum universe of scc1.
self.scc_universes[scc1] = scc1_universe; self.scc_universes[scc1] = scc1_universe;
// At this point, `scc_placeholder[scc1]` stores the placeholder that // At this point, `scc_placeholders[scc1]` stores the placeholder that
// `scc1` must be equal to, if any. // `scc1` must be equal to, if any.
if let Some(scc1_placeholder) = self.scc_placeholders[scc1] { if let Some(scc1_placeholder) = self.scc_placeholders[scc1] {
debug!( debug!(

View file

@ -234,7 +234,7 @@ pub enum UndefinedBehaviorInfo<'tcx> {
}, },
/// Something was divided by 0 (x / 0). /// Something was divided by 0 (x / 0).
DivisionByZero, DivisionByZero,
/// Something was "remaineded" by 0 (x % 0). /// Something was "remainded" by 0 (x % 0).
RemainderByZero, RemainderByZero,
/// Signed division overflowed (INT_MIN / -1). /// Signed division overflowed (INT_MIN / -1).
DivisionOverflow, DivisionOverflow,

View file

@ -444,7 +444,7 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {
// we lower the guard. // we lower the guard.
let target_block = self.cfg.start_new_block(); let target_block = self.cfg.start_new_block();
let mut schedule_drops = true; let mut schedule_drops = true;
// We keep a stack of all of the bindings and type descriptions // We keep a stack of all of the bindings and type ascriptions
// from the parent candidates that we visit, that also need to // from the parent candidates that we visit, that also need to
// be bound for each candidate. // be bound for each candidate.
traverse_candidate( traverse_candidate(

View file

@ -234,7 +234,7 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {
}; };
TerminatorKind::if_(self.tcx, Operand::Copy(place), true_bb, false_bb) TerminatorKind::if_(self.tcx, Operand::Copy(place), true_bb, false_bb)
} else { } else {
// The switch may be inexhaustible so we have a catch all block // The switch may be inexhaustive so we have a catch all block
debug_assert_eq!(options.len() + 1, target_blocks.len()); debug_assert_eq!(options.len() + 1, target_blocks.len());
let otherwise_block = *target_blocks.last().unwrap(); let otherwise_block = *target_blocks.last().unwrap();
let switch_targets = SwitchTargets::new( let switch_targets = SwitchTargets::new(

View file

@ -1650,7 +1650,7 @@ impl<'p, 'tcx> fmt::Debug for DeconstructedPat<'p, 'tcx> {
} }
// Without `cx`, we can't know which field corresponds to which, so we can't // Without `cx`, we can't know which field corresponds to which, so we can't
// get the names of the fields. Instead we just display everything as a simple // get the names of the fields. Instead we just display everything as a tuple
// struct, which should be good enough. // struct, which should be good enough.
write!(f, "(")?; write!(f, "(")?;
for p in self.iter_fields() { for p in self.iter_fields() {

View file

@ -276,7 +276,7 @@ impl<'a> Parser<'a> {
lhs = self.parse_assoc_op_ascribe(lhs, lhs_span)?; lhs = self.parse_assoc_op_ascribe(lhs, lhs_span)?;
continue; continue;
} else if op == AssocOp::DotDot || op == AssocOp::DotDotEq { } else if op == AssocOp::DotDot || op == AssocOp::DotDotEq {
// If we did not have to handle `x..`/`x..=`, it would be pretty easy to // If we didn't have to handle `x..`/`x..=`, it would be pretty easy to
// generalise it to the Fixity::None code. // generalise it to the Fixity::None code.
lhs = self.parse_range_expr(prec, lhs, op, cur_op_span)?; lhs = self.parse_range_expr(prec, lhs, op, cur_op_span)?;
break; break;

View file

@ -144,7 +144,7 @@ impl<'a, 'tcx> Annotator<'a, 'tcx> {
} }
if !self.tcx.features().staged_api { if !self.tcx.features().staged_api {
// Propagate instability. This can happen even for non-staged-api crates in case // Propagate unstability. This can happen even for non-staged-api crates in case
// -Zforce-unstable-if-unmarked is set. // -Zforce-unstable-if-unmarked is set.
if let Some(stab) = self.parent_stab { if let Some(stab) = self.parent_stab {
if inherit_deprecation.yes() && stab.level.is_unstable() { if inherit_deprecation.yes() && stab.level.is_unstable() {