bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #90420 - GuillaumeGomez:rustdoc-internals-feature, r=camelid

Browse source 
Create rustdoc_internals feature gate

As suggested by ``@camelid`` [here](https://github.com/rust-lang/rust/pull/90398#issuecomment-955093851), since `doc_keyword` and `doc_primitive` aren't meant to be stabilized, we could put them behind a same feature flag.

This is pretty much what it would look like (needs to update the tests too).

The tracking issue is https://github.com/rust-lang/rust/issues/90418.

What do you think ``@rust-lang/rustdoc`` ?
This commit is contained in:
Guillaume Gomez 2021-11-24 22:56:37 +01:00 • committed by GitHub
commit a6a1d7ca29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
22 changed files with 72 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_ast_passes/src/feature_gate.rs
View file

@ -325,8 +325,12 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
cfg_hide => doc_cfg_hide
masked => doc_masked
notable_trait => doc_notable_trait
keyword => doc_keyword
);
if nested_meta.has_name(sym::keyword) {
let msg = "`#[doc(keyword)]` is meant for internal use only";
gate_feature_post!(self, rustdoc_internals, attr.span, msg);
}
}
}