bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #4947 - rust-lang:doc-main-extern-crate, r=flip1995

Browse source 
Avoid needless_doctest_main on 'extern crate'

This fixes #4927.

r? @flip1995

changelog: none
This commit is contained in:
bors 2019-12-24 15:03:54 +00:00
commit a68ef55dbf
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
clippy_lints/src/doc.rs
View file

@ -389,8 +389,10 @@ fn check_doc<'a, Events: Iterator<Item = (pulldown_cmark::Event<'a>, Range<usize
headers
}
static LEAVE_MAIN_PATTERNS: &[&str] = &["static", "fn main() {}", "extern crate"];
fn check_code(cx: &LateContext<'_, '_>, text: &str, span: Span) {
if text.contains("fn main() {") && !(text.contains("static") || text.contains("fn main() {}")) {
if text.contains("fn main() {") && !LEAVE_MAIN_PATTERNS.iter().any(|p| text.contains(p)) {
span_lint(cx, NEEDLESS_DOCTEST_MAIN, span, "needless `fn main` in doctest");
}
}