bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

less uB in i8

Browse source
This commit is contained in:
Giles Cope 2021-03-04 22:11:04 +00:00
parent d07c43af31
commit a678b9a2ae
No known key found for this signature in database
GPG key ID: DF85161DAE0FF36B
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
library/alloc/src/string.rs
View file

@ -2254,14 +2254,18 @@ static DEC_DIGITS_LUT: &[u8; 200] = b"0001020304050607080910111213141516171819\
impl ToString for i8 { impl ToString for i8 {
#[inline] #[inline]
fn to_string(&self) -> String { fn to_string(&self) -> String {
let mut vec: Vec<u8> = if *self < 0 { let mut n = *self;
let mut vec: Vec<u8> = if n < 0 {
// convert the negative num to positive by summing 1 to it's 2 complement
// ( -128u8.abs() would panic )
n = (!n).wrapping_add(1);
let mut v = Vec::with_capacity(4); let mut v = Vec::with_capacity(4);
v.push(b'-'); v.push(b'-');
v v
} else { } else {
Vec::with_capacity(3) Vec::with_capacity(3)
}; };
let mut n = self.abs(); let mut n = n as u8;
if n >= 10 { if n >= 10 {
if n >= 100 { if n >= 100 {
n -= 100; n -= 100;