bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Wrap some overlong comments.

Browse source
This commit is contained in:
Nicholas Nethercote 2023-10-30 15:33:05 +11:00
parent 85e56e81f8
commit a60d6438dc
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
compiler/rustc_interface/src/passes.rs
View file

@ -880,16 +880,18 @@ fn analysis(tcx: TyCtxt<'_>, (): ()) -> Result<()> {
let trait_ref = ty::Binder::dummy(ty::TraitRef::identity(tcx, tr)); let trait_ref = ty::Binder::dummy(ty::TraitRef::identity(tcx, tr));
// A slightly edited version of the code in `rustc_trait_selection::traits::vtable::vtable_entries`, // A slightly edited version of the code in
// that works without self type and just counts number of entries. // `rustc_trait_selection::traits::vtable::vtable_entries`, that works without self
// type and just counts number of entries.
// //
// Note that this is technically wrong, for traits which have associated types in supertraits: // Note that this is technically wrong, for traits which have associated types in
// supertraits:
// //
// trait A: AsRef<Self::T> + AsRef<()> { type T; } // trait A: AsRef<Self::T> + AsRef<()> { type T; }
// //
// Without self type we can't normalize `Self::T`, so we can't know if `AsRef<Self::T>` and // Without self type we can't normalize `Self::T`, so we can't know if `AsRef<Self::T>`
// `AsRef<()>` are the same trait, thus we assume that those are different, and potentially // and `AsRef<()>` are the same trait, thus we assume that those are different, and
// over-estimate how many vtable entries there are. // potentially over-estimate how many vtable entries there are.
// //
// Similarly this is wrong for traits that have methods with possibly-impossible bounds. // Similarly this is wrong for traits that have methods with possibly-impossible bounds.
// For example: // For example:
@ -916,10 +918,10 @@ fn analysis(tcx: TyCtxt<'_>, (): ()) -> Result<()> {
let own_existential_entries = let own_existential_entries =
tcx.own_existential_vtable_entries(trait_ref.def_id()); tcx.own_existential_vtable_entries(trait_ref.def_id());
// The original code here ignores the method if its predicates are impossible. // The original code here ignores the method if its predicates are
// We can't really do that as, for example, all not trivial bounds on generic // impossible. We can't really do that as, for example, all not trivial
// parameters are impossible (since we don't know the parameters...), // bounds on generic parameters are impossible (since we don't know the
// see the comment above. // parameters...), see the comment above.
entries_ignoring_upcasting += own_existential_entries.len(); entries_ignoring_upcasting += own_existential_entries.len();
if emit_vptr { if emit_vptr {