bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

errors: disable directionality isolation markers

Browse source 
Fluent diagnostics can insert directionality isolation markers around
interpolated variables indicating that there may be a shift from
right-to-left to left-to-right text (or vice-versa). These are disabled
because they are sometimes visible in the error output, but may be worth
investigating in future (for example: if type names are left-to-right
and the surrounding diagnostic messages are right-to-left, then these
might be helpful).

Signed-off-by: David Wood <david.wood@huawei.com>
This commit is contained in:
David Wood 2022-03-31 10:14:21 +01:00
parent 9956d4f99d
commit a52b5072ac
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_error_messages/src/lib.rs
View file

@ -111,6 +111,13 @@ pub fn fluent_bundle(
trace!(?locale); trace!(?locale);
let mut bundle = FluentBundle::new(vec![locale]); let mut bundle = FluentBundle::new(vec![locale]);
// Fluent diagnostics can insert directionality isolation markers around interpolated variables
// indicating that there may be a shift from right-to-left to left-to-right text (or
// vice-versa). These are disabled because they are sometimes visible in the error output, but
// may be worth investigating in future (for example: if type names are left-to-right and the
// surrounding diagnostic messages are right-to-left, then these might be helpful).
bundle.set_use_isolating(false);
if let Some(requested_locale) = requested_locale { if let Some(requested_locale) = requested_locale {
let mut sysroot = sysroot.to_path_buf(); let mut sysroot = sysroot.to_path_buf();
sysroot.push("share"); sysroot.push("share");
@ -161,6 +168,8 @@ pub fn fallback_fluent_bundle() -> Result<Lrc<FluentBundle>, TranslationBundleEr
.map_err(TranslationBundleError::from)?; .map_err(TranslationBundleError::from)?;
trace!(?fallback_resource); trace!(?fallback_resource);
let mut fallback_bundle = FluentBundle::new(vec![langid!("en-US")]); let mut fallback_bundle = FluentBundle::new(vec![langid!("en-US")]);
// See comment in `fluent_bundle`.
fallback_bundle.set_use_isolating(false);
fallback_bundle.add_resource(fallback_resource).map_err(TranslationBundleError::from)?; fallback_bundle.add_resource(fallback_resource).map_err(TranslationBundleError::from)?;
let fallback_bundle = Lrc::new(fallback_bundle); let fallback_bundle = Lrc::new(fallback_bundle);
Ok(fallback_bundle) Ok(fallback_bundle)