bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #111069 - ozkanonur:remove-pointless-fixme, r=albertlarsan68

Browse source 
remove pointless `FIXME` in `bootstrap::download`

The suggestion given by `FIXME` to use `CompilerMetadata` for `download_toolchain` in `bootstrap::download` can result in more confusion. This is because `stamp_key` is not always a date; it can also be a commit hash. Additionally, unlike in `download_beta_toolchain`, in the `download_ci_rustc` function, `version` and `commit` values are calculated separately.
This commit is contained in:
Dylan DPC 2023-05-04 00:17:26 +05:30 • committed by GitHub
commit a47fa34558
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/bootstrap/download.rs
View file

@ -427,7 +427,6 @@ impl Config {
fn download_toolchain(
&self,
// FIXME(ozkanonur) use CompilerMetadata instead of `version: &str`
version: &str,
sysroot: &str,
stamp_key: &str,