bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

add a rustc::query_stability lint

Browse source
This commit is contained in:
lcnr 2022-01-05 13:02:16 +01:00
parent 25862ffc8d
commit a1a30f7548
42 changed files with 302 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

162
compiler/rustc_passes/src/check_attr.rs
View file

@ -62,7 +62,7 @@ impl CheckAttrVisitor<'_> {
fn check_attributes(
&self,
hir_id: HirId,
span: &Span,
span: Span,
target: Target,
item: Option<ItemLike<'_>>,
) {
@ -81,7 +81,7 @@ impl CheckAttrVisitor<'_> {
}
sym::target_feature => self.check_target_feature(hir_id, attr, span, target),
sym::track_caller => {
self.check_track_caller(hir_id, &attr.span, attrs, span, target)
self.check_track_caller(hir_id, attr.span, attrs, span, target)
}
sym::doc => self.check_doc_attrs(
attr,
@ -106,6 +106,9 @@ impl CheckAttrVisitor<'_> {
sym::rustc_legacy_const_generics => {
self.check_rustc_legacy_const_generics(&attr, span, target, item)
}
sym::rustc_lint_query_instability => {
self.check_rustc_lint_query_instability(&attr, span, target)
}
sym::rustc_clean
| sym::rustc_dirty
| sym::rustc_if_this_changed
@ -253,7 +256,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if an `#[inline]` is applied to a function or a closure. Returns `true` if valid.
fn check_inline(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) -> bool {
fn check_inline(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
match target {
Target::Fn
| Target::Closure
@ -296,7 +299,7 @@ impl CheckAttrVisitor<'_> {
E0518,
"attribute should be applied to function or closure",
)
.span_label(*span, "not a function or closure")
.span_label(span, "not a function or closure")
.emit();
false
}
@ -335,7 +338,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[naked]` is applied to a function definition.
fn check_naked(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) -> bool {
fn check_naked(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
match target {
Target::Fn
| Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) => true,
@ -354,7 +357,7 @@ impl CheckAttrVisitor<'_> {
attr.span,
"attribute should be applied to a function definition",
)
.span_label(*span, "not a function definition")
.span_label(span, "not a function definition")
.emit();
false
}
@ -362,7 +365,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[cmse_nonsecure_entry]` is applied to a function definition.
fn check_cmse_nonsecure_entry(&self, attr: &Attribute, span: &Span, target: Target) -> bool {
fn check_cmse_nonsecure_entry(&self, attr: &Attribute, span: Span, target: Target) -> bool {
match target {
Target::Fn
| Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) => true,
@ -373,7 +376,7 @@ impl CheckAttrVisitor<'_> {
attr.span,
"attribute should be applied to a function definition",
)
.span_label(*span, "not a function definition")
.span_label(span, "not a function definition")
.emit();
false
}
@ -384,16 +387,16 @@ impl CheckAttrVisitor<'_> {
fn check_track_caller(
&self,
hir_id: HirId,
attr_span: &Span,
attr_span: Span,
attrs: &[Attribute],
span: &Span,
span: Span,
target: Target,
) -> bool {
match target {
_ if attrs.iter().any(|attr| attr.has_name(sym::naked)) => {
struct_span_err!(
self.tcx.sess,
*attr_span,
attr_span,
E0736,
"cannot use `#[track_caller]` with `#[naked]`",
)
@ -414,11 +417,11 @@ impl CheckAttrVisitor<'_> {
_ => {
struct_span_err!(
self.tcx.sess,
*attr_span,
attr_span,
E0739,
"attribute should be applied to function"
)
.span_label(*span, "not a function")
.span_label(span, "not a function")
.emit();
false
}
@ -430,7 +433,7 @@ impl CheckAttrVisitor<'_> {
&self,
hir_id: HirId,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
) -> bool {
match target {
@ -450,7 +453,7 @@ impl CheckAttrVisitor<'_> {
E0701,
"attribute can only be applied to a struct or enum"
)
.span_label(*span, "not a struct or enum")
.span_label(span, "not a struct or enum")
.emit();
false
}
@ -458,7 +461,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if the `#[marker]` attribute on an `item` is valid. Returns `true` if valid.
fn check_marker(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) -> bool {
fn check_marker(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
match target {
Target::Trait => true,
// FIXME(#80564): We permit struct fields, match arms and macro defs to have an
@ -473,7 +476,7 @@ impl CheckAttrVisitor<'_> {
self.tcx
.sess
.struct_span_err(attr.span, "attribute can only be applied to a trait")
.span_label(*span, "not a trait")
.span_label(span, "not a trait")
.emit();
false
}
@ -505,7 +508,7 @@ impl CheckAttrVisitor<'_> {
&self,
hir_id: HirId,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
) -> bool {
match target {
@ -521,7 +524,7 @@ impl CheckAttrVisitor<'_> {
being phased out; it will become a hard error in \
a future release!",
)
.span_label(*span, "not a function")
.span_label(span, "not a function")
.emit();
});
true
@ -538,7 +541,7 @@ impl CheckAttrVisitor<'_> {
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to a function")
.span_label(*span, "not a function")
.span_label(span, "not a function")
.emit();
false
}
@ -1090,7 +1093,7 @@ impl CheckAttrVisitor<'_> {
}
/// Warns against some misuses of `#[pass_by_value]`
fn check_pass_by_value(&self, attr: &Attribute, span: &Span, target: Target) -> bool {
fn check_pass_by_value(&self, attr: &Attribute, span: Span, target: Target) -> bool {
match target {
Target::Struct | Target::Enum | Target::TyAlias => true,
_ => {
@ -1100,7 +1103,7 @@ impl CheckAttrVisitor<'_> {
attr.span,
"`pass_by_value` attribute should be applied to a struct, enum or type alias.",
)
.span_label(*span, "is not a struct, enum or type alias")
.span_label(span, "is not a struct, enum or type alias")
.emit();
false
}
@ -1108,13 +1111,7 @@ impl CheckAttrVisitor<'_> {
}
/// Warns against some misuses of `#[must_use]`
fn check_must_use(
&self,
hir_id: HirId,
attr: &Attribute,
span: &Span,
_target: Target,
) -> bool {
fn check_must_use(&self, hir_id: HirId, attr: &Attribute, span: Span, _target: Target) -> bool {
let node = self.tcx.hir().get(hir_id);
if let Some(fn_node) = node.fn_kind() {
if let rustc_hir::IsAsync::Async = fn_node.asyncness() {
@ -1125,7 +1122,7 @@ impl CheckAttrVisitor<'_> {
function, not the value within",
)
.span_label(
*span,
span,
"this attribute does nothing, the `Future`s \
returned by async functions are already `must_use`",
)
@ -1139,14 +1136,14 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[must_not_suspend]` is applied to a function. Returns `true` if valid.
fn check_must_not_suspend(&self, attr: &Attribute, span: &Span, target: Target) -> bool {
fn check_must_not_suspend(&self, attr: &Attribute, span: Span, target: Target) -> bool {
match target {
Target::Struct | Target::Enum | Target::Union | Target::Trait => true,
_ => {
self.tcx
.sess
.struct_span_err(attr.span, "`must_not_suspend` attribute should be applied to a struct, enum, or trait")
.span_label(*span, "is not a struct, enum, or trait")
.span_label(span, "is not a struct, enum, or trait")
.emit();
false
}
@ -1154,7 +1151,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[cold]` is applied to a non-function. Returns `true` if valid.
fn check_cold(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) {
fn check_cold(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
match target {
Target::Fn | Target::Method(..) | Target::ForeignFn | Target::Closure => {}
// FIXME(#80564): We permit struct fields, match arms and macro defs to have an
@ -1174,7 +1171,7 @@ impl CheckAttrVisitor<'_> {
being phased out; it will become a hard error in \
a future release!",
)
.span_label(*span, "not a function")
.span_label(span, "not a function")
.emit();
});
}
@ -1182,7 +1179,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[link]` is applied to an item other than a foreign module.
fn check_link(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) {
fn check_link(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
match target {
Target::ForeignMod => {}
_ => {
@ -1194,7 +1191,7 @@ impl CheckAttrVisitor<'_> {
a future release!",
);
diag.span_label(*span, "not an `extern` block");
diag.span_label(span, "not an `extern` block");
diag.emit();
});
}
@ -1202,7 +1199,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[link_name]` is applied to an item other than a foreign function or static.
fn check_link_name(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) {
fn check_link_name(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
match target {
Target::ForeignFn | Target::ForeignStatic => {}
// FIXME(#80564): We permit struct fields, match arms and macro defs to have an
@ -1236,7 +1233,7 @@ impl CheckAttrVisitor<'_> {
}
}
diag.span_label(*span, "not a foreign function or static");
diag.span_label(span, "not a foreign function or static");
diag.emit();
});
}
@ -1244,7 +1241,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[no_link]` is applied to an `extern crate`. Returns `true` if valid.
fn check_no_link(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) -> bool {
fn check_no_link(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
match target {
Target::ExternCrate => true,
// FIXME(#80564): We permit struct fields, match arms and macro defs to have an
@ -1262,7 +1259,7 @@ impl CheckAttrVisitor<'_> {
attr.span,
"attribute should be applied to an `extern crate` item",
)
.span_label(*span, "not an `extern crate` item")
.span_label(span, "not an `extern crate` item")
.emit();
false
}
@ -1278,7 +1275,7 @@ impl CheckAttrVisitor<'_> {
&self,
hir_id: HirId,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
) -> bool {
match target {
@ -1299,7 +1296,7 @@ impl CheckAttrVisitor<'_> {
attr.span,
"attribute should be applied to a free function, impl method or static",
)
.span_label(*span, "not a free function, impl method or static")
.span_label(span, "not a free function, impl method or static")
.emit();
false
}
@ -1309,14 +1306,14 @@ impl CheckAttrVisitor<'_> {
fn check_rustc_layout_scalar_valid_range(
&self,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
) -> bool {
if target != Target::Struct {
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to a struct")
.span_label(*span, "not a struct")
.span_label(span, "not a struct")
.emit();
return false;
}
@ -1341,7 +1338,7 @@ impl CheckAttrVisitor<'_> {
fn check_rustc_legacy_const_generics(
&self,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
item: Option<ItemLike<'_>>,
) -> bool {
@ -1350,7 +1347,7 @@ impl CheckAttrVisitor<'_> {
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to a function")
.span_label(*span, "not a function")
.span_label(span, "not a function")
.emit();
return false;
}
@ -1436,6 +1433,25 @@ impl CheckAttrVisitor<'_> {
}
}
fn check_rustc_lint_query_instability(
&self,
attr: &Attribute,
span: Span,
target: Target,
) -> bool {
let is_function = matches!(target, Target::Fn | Target::Method(..));
if !is_function {
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to a function")
.span_label(span, "not a function")
.emit();
false
} else {
true
}
}
/// Checks that the dep-graph debugging attributes are only present when the query-dep-graph
/// option is passed to the compiler.
fn check_rustc_dirty_clean(&self, attr: &Attribute) -> bool {
@ -1451,7 +1467,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[link_section]` is applied to a function or static.
fn check_link_section(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) {
fn check_link_section(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
match target {
Target::Static | Target::Fn | Target::Method(..) => {}
// FIXME(#80564): We permit struct fields, match arms and macro defs to have an
@ -1471,7 +1487,7 @@ impl CheckAttrVisitor<'_> {
being phased out; it will become a hard error in \
a future release!",
)
.span_label(*span, "not a function or static")
.span_label(span, "not a function or static")
.emit();
});
}
@ -1479,7 +1495,7 @@ impl CheckAttrVisitor<'_> {
}
/// Checks if `#[no_mangle]` is applied to a function or static.
fn check_no_mangle(&self, hir_id: HirId, attr: &Attribute, span: &Span, target: Target) {
fn check_no_mangle(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
match target {
Target::Static | Target::Fn => {}
Target::Method(..) if self.is_impl_item(hir_id) => {}
@ -1509,7 +1525,7 @@ impl CheckAttrVisitor<'_> {
being phased out; it will become a hard error in \
a future release!",
)
.span_label(*span, format!("foreign {}", foreign_item_kind))
.span_label(span, format!("foreign {}", foreign_item_kind))
.note("symbol names in extern blocks are not mangled")
.span_suggestion(
attr.span,
@ -1532,7 +1548,7 @@ impl CheckAttrVisitor<'_> {
being phased out; it will become a hard error in \
a future release!",
)
.span_label(*span, "not a free function, impl method or static")
.span_label(span, "not a free function, impl method or static")
.emit();
});
}
@ -1543,7 +1559,7 @@ impl CheckAttrVisitor<'_> {
fn check_repr(
&self,
attrs: &[Attribute],
span: &Span,
span: Span,
target: Target,
item: Option<ItemLike<'_>>,
hir_id: HirId,
@ -1677,7 +1693,7 @@ impl CheckAttrVisitor<'_> {
"{}",
&format!("attribute should be applied to {} {}", article, allowed_targets)
)
.span_label(*span, &format!("not {} {}", article, allowed_targets))
.span_label(span, &format!("not {} {}", article, allowed_targets))
.emit();
}
@ -1740,7 +1756,7 @@ impl CheckAttrVisitor<'_> {
&self,
hir_id: HirId,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
attrs: &[Attribute],
) -> bool {
@ -1773,7 +1789,7 @@ impl CheckAttrVisitor<'_> {
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to a macro")
.span_label(*span, "not a macro")
.span_label(span, "not a macro")
.emit();
false
}
@ -1786,7 +1802,7 @@ impl CheckAttrVisitor<'_> {
&self,
hir_id: HirId,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
) -> bool {
match target {
@ -1807,7 +1823,7 @@ impl CheckAttrVisitor<'_> {
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to `const fn`")
.span_label(*span, "not a `const fn`")
.span_label(span, "not a `const fn`")
.emit();
false
}
@ -1818,7 +1834,7 @@ impl CheckAttrVisitor<'_> {
fn check_default_method_body_is_const(
&self,
attr: &Attribute,
span: &Span,
span: Span,
target: Target,
) -> bool {
match target {
@ -1830,14 +1846,14 @@ impl CheckAttrVisitor<'_> {
attr.span,
"attribute should be applied to a trait method with body",
)
.span_label(*span, "not a trait method or missing a body")
.span_label(span, "not a trait method or missing a body")
.emit();
false
}
}
}
fn check_stability_promotable(&self, attr: &Attribute, _span: &Span, target: Target) -> bool {
fn check_stability_promotable(&self, attr: &Attribute, _span: Span, target: Target) -> bool {
match target {
Target::Expression => {
self.tcx
@ -1850,7 +1866,7 @@ impl CheckAttrVisitor<'_> {
}
}
fn check_deprecated(&self, hir_id: HirId, attr: &Attribute, _span: &Span, target: Target) {
fn check_deprecated(&self, hir_id: HirId, attr: &Attribute, _span: Span, target: Target) {
match target {
Target::Closure | Target::Expression | Target::Statement | Target::Arm => {
self.tcx.struct_span_lint_hir(UNUSED_ATTRIBUTES, hir_id, attr.span, |lint| {
@ -1912,29 +1928,29 @@ impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {
}
let target = Target::from_item(item);
self.check_attributes(item.hir_id(), &item.span, target, Some(ItemLike::Item(item)));
self.check_attributes(item.hir_id(), item.span, target, Some(ItemLike::Item(item)));
intravisit::walk_item(self, item)
}
fn visit_generic_param(&mut self, generic_param: &'tcx hir::GenericParam<'tcx>) {
let target = Target::from_generic_param(generic_param);
self.check_attributes(generic_param.hir_id, &generic_param.span, target, None);
self.check_attributes(generic_param.hir_id, generic_param.span, target, None);
intravisit::walk_generic_param(self, generic_param)
}
fn visit_trait_item(&mut self, trait_item: &'tcx TraitItem<'tcx>) {
let target = Target::from_trait_item(trait_item);
self.check_attributes(trait_item.hir_id(), &trait_item.span, target, None);
self.check_attributes(trait_item.hir_id(), trait_item.span, target, None);
intravisit::walk_trait_item(self, trait_item)
}
fn visit_field_def(&mut self, struct_field: &'tcx hir::FieldDef<'tcx>) {
self.check_attributes(struct_field.hir_id, &struct_field.span, Target::Field, None);
self.check_attributes(struct_field.hir_id, struct_field.span, Target::Field, None);
intravisit::walk_field_def(self, struct_field);
}
fn visit_arm(&mut self, arm: &'tcx hir::Arm<'tcx>) {
self.check_attributes(arm.hir_id, &arm.span, Target::Arm, None);
self.check_attributes(arm.hir_id, arm.span, Target::Arm, None);
intravisit::walk_arm(self, arm);
}
@ -1942,7 +1958,7 @@ impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {
let target = Target::from_foreign_item(f_item);
self.check_attributes(
f_item.hir_id(),
&f_item.span,
f_item.span,
target,
Some(ItemLike::ForeignItem(f_item)),
);
@ -1951,14 +1967,14 @@ impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {
fn visit_impl_item(&mut self, impl_item: &'tcx hir::ImplItem<'tcx>) {
let target = target_from_impl_item(self.tcx, impl_item);
self.check_attributes(impl_item.hir_id(), &impl_item.span, target, None);
self.check_attributes(impl_item.hir_id(), impl_item.span, target, None);
intravisit::walk_impl_item(self, impl_item)
}
fn visit_stmt(&mut self, stmt: &'tcx hir::Stmt<'tcx>) {
// When checking statements ignore expressions, they will be checked later.
if let hir::StmtKind::Local(ref l) = stmt.kind {
self.check_attributes(l.hir_id, &stmt.span, Target::Statement, None);
self.check_attributes(l.hir_id, stmt.span, Target::Statement, None);
}
intravisit::walk_stmt(self, stmt)
}
@ -1969,7 +1985,7 @@ impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {
_ => Target::Expression,
};
self.check_attributes(expr.hir_id, &expr.span, target, None);
self.check_attributes(expr.hir_id, expr.span, target, None);
intravisit::walk_expr(self, expr)
}
@ -1979,12 +1995,12 @@ impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {
generics: &'tcx hir::Generics<'tcx>,
item_id: HirId,
) {
self.check_attributes(variant.id, &variant.span, Target::Variant, None);
self.check_attributes(variant.id, variant.span, Target::Variant, None);
intravisit::walk_variant(self, variant, generics, item_id)
}
fn visit_param(&mut self, param: &'tcx hir::Param<'tcx>) {
self.check_attributes(param.hir_id, &param.span, Target::Param, None);
self.check_attributes(param.hir_id, param.span, Target::Param, None);
intravisit::walk_param(self, param);
}
@ -2076,7 +2092,7 @@ fn check_mod_attrs(tcx: TyCtxt<'_>, module_def_id: LocalDefId) {
let check_attr_visitor = &mut CheckAttrVisitor { tcx };
tcx.hir().visit_item_likes_in_module(module_def_id, &mut check_attr_visitor.as_deep_visitor());
if module_def_id.is_top_level_module() {
check_attr_visitor.check_attributes(CRATE_HIR_ID, &DUMMY_SP, Target::Mod, None);
check_attr_visitor.check_attributes(CRATE_HIR_ID, DUMMY_SP, Target::Mod, None);
check_invalid_crate_level_attr(tcx, tcx.hir().krate_attrs());
}
}