Address review comments
This commit is contained in:
parent
cfb04795a1
commit
a197ff3259
2 changed files with 33 additions and 1 deletions
|
@ -356,7 +356,7 @@ where
|
||||||
|
|
||||||
match result {
|
match result {
|
||||||
Ok(_) => self.pos += buf.len() as u64,
|
Ok(_) => self.pos += buf.len() as u64,
|
||||||
// The only posible error condition is EOF
|
// The only possible error condition is EOF, so place the cursor at "EOF"
|
||||||
Err(_) => self.pos = self.inner.as_ref().len() as u64,
|
Err(_) => self.pos = self.inner.as_ref().len() as u64,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -653,6 +653,38 @@ fn test_take_wrong_length() {
|
||||||
let _ = reader.read(&mut buffer[..]);
|
let _ = reader.read(&mut buffer[..]);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn slice_read_exact_eof() {
|
||||||
|
let slice = &b"123456"[..];
|
||||||
|
|
||||||
|
let mut r = slice;
|
||||||
|
assert!(r.read_exact(&mut [0; 10]).is_err());
|
||||||
|
assert!(r.is_empty());
|
||||||
|
|
||||||
|
let mut r = slice;
|
||||||
|
let buf = &mut [0; 10];
|
||||||
|
let mut buf = BorrowedBuf::from(buf.as_mut_slice());
|
||||||
|
assert!(r.read_buf_exact(buf.unfilled()).is_err());
|
||||||
|
assert!(r.is_empty());
|
||||||
|
assert_eq!(buf.filled(), b"123456");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn cursor_read_exact_eof() {
|
||||||
|
let slice = Cursor::new(b"123456");
|
||||||
|
|
||||||
|
let mut r = slice.clone();
|
||||||
|
assert!(r.read_exact(&mut [0; 10]).is_err());
|
||||||
|
assert!(r.is_empty());
|
||||||
|
|
||||||
|
let mut r = slice;
|
||||||
|
let buf = &mut [0; 10];
|
||||||
|
let mut buf = BorrowedBuf::from(buf.as_mut_slice());
|
||||||
|
assert!(r.read_buf_exact(buf.unfilled()).is_err());
|
||||||
|
assert!(r.is_empty());
|
||||||
|
assert_eq!(buf.filled(), b"123456");
|
||||||
|
}
|
||||||
|
|
||||||
#[bench]
|
#[bench]
|
||||||
fn bench_take_read(b: &mut test::Bencher) {
|
fn bench_take_read(b: &mut test::Bencher) {
|
||||||
b.iter(|| {
|
b.iter(|| {
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue